Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Broaden SecureSettingsFactory to include http transports #12907

Merged
merged 4 commits into from
Mar 28, 2024

Address code review comments, added more tests

fdba4b7
Select commit
Loading
Failed to load commit list.
Merged

[FEATURE] Broaden SecureSettingsFactory to include http transports #12907

Address code review comments, added more tests
fdba4b7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 28, 2024 in 0s

71.41% (target 70.00%)

View this Pull Request on Codecov

71.41% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 90.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 71.41%. Comparing base (b15cb0c) to head (fdba4b7).
Report is 104 commits behind head on main.

Files Patch % Lines
...tp/netty4/ssl/SecureNetty4HttpServerTransport.java 88.88% 2 Missing and 1 partial ⚠️
...a/org/opensearch/common/network/NetworkModule.java 94.11% 0 Missing and 1 partial ⚠️
...earch/plugins/SecureTransportSettingsProvider.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12907      +/-   ##
============================================
- Coverage     71.42%   71.41%   -0.01%     
- Complexity    59978    60239     +261     
============================================
  Files          4985     5017      +32     
  Lines        282275   283902    +1627     
  Branches      40946    41149     +203     
============================================
+ Hits         201603   202737    +1134     
- Misses        63999    64292     +293     
- Partials      16673    16873     +200

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov