Replace configureEach with all for publication iteration #12876

zelinh · 2024-03-22T21:18:45Z

Description

Change the publication iteration to all to resolve incompatibility on security plugin.

I tested locally and it built successfully.

☁  ~/workplace/security[main] ./gradlew assemble
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.5
  OS Info               : Mac OS X 14.3 (x86_64)
  JDK Version           : 21 (Oracle JDK)
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/jdk-21.jdk/Contents/Home
  Random Testing Seed   : C82B0FF391C689CE
  In FIPS 140 mode      : false
=======================================

> Task :compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.5/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 44s
11 actionable tasks: 11 executed

and the Pom validation tasks are executed successfully as well.

☁  ~/workplace/security[main] ./gradlew validatePom --info
Initialized native services in: /Users/zelinhao/.gradle/native
Initialized jansi services in: /Users/zelinhao/.gradle/native
Received JVM installation metadata from '/Library/Java/JavaVirtualMachines/jdk-21.jdk/Contents/Home': {JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk-21.jdk/Contents/Home, JAVA_VERSION=21.0.2, JAVA_VENDOR=Oracle Corporation, RUNTIME_NAME=Java(TM) SE Runtime Environment, RUNTIME_VERSION=21.0.2+13-LTS-58, VM_NAME=Java HotSpot(TM) 64-Bit Server VM, VM_VERSION=21.0.2+13-LTS-58, VM_VENDOR=Oracle Corporation, OS_ARCH=x86_64}
The client will now receive all logging from the daemon (pid: 64282). The daemon log file: /Users/zelinhao/.gradle/daemon/8.5/daemon-64282.out.log
Starting 3rd build in daemon [uptime: 13 mins 49.216 secs, performance: 99%, GC rate: 0.00/s, heap usage: 0% of 512 MiB, non-heap usage: 26% of 384 MiB]
Using 12 worker leases.
Now considering [/Users/zelinhao/workplace/security] as hierarchies to watch
Watching the file system is configured to be enabled if available
File system watching is active
Starting Build
Settings evaluated using settings file '/Users/zelinhao/workplace/security/settings.gradle'.
Projects loaded. Root project using build file '/Users/zelinhao/workplace/security/build.gradle'.
Included projects: [root project 'opensearch-security']

> Configure project :
Evaluating root project 'opensearch-security' using build file '/Users/zelinhao/workplace/security/build.gradle'.
Invalidating in-memory cache of /Users/zelinhao/.gradle/caches/journal-1/file-access.bin
------------------------------------------------------------------------
Detecting the operating system and CPU architecture
------------------------------------------------------------------------
os.detected.name=osx
os.detected.arch=x86_64
os.detected.bitness=64
os.detected.version=14.3
os.detected.version.major=14
os.detected.version.minor=3
os.detected.classifier=osx-x86_64
All projects evaluated.
Task name matched 'validatePom'
Selected primary task 'validatePom' from project :
Tasks to be executed: [task ':generatePomFileForMavenPublication', task ':generatePomFileForNebulaPublication', task ':generatePomFileForPluginZipPublication', task ':validateMavenPom', task ':validateNebulaPom', task ':validatePluginZipPom', task ':validatePom']
Tasks that were excluded: []
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.5
  OS Info               : Mac OS X 14.3 (x86_64)
  JDK Version           : 21 (Oracle JDK)
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/jdk-21.jdk/Contents/Home
  Random Testing Seed   : 7B7B1C62ACD616C6
  In FIPS 140 mode      : false
=======================================
Resolve mutations for :generatePomFileForMavenPublication (Thread[#310,Execution worker,5,main]) started.
:generatePomFileForMavenPublication (Thread[#314,Execution worker Thread 5,5,main]) started.

> Task :generatePomFileForMavenPublication
Caching disabled for task ':generatePomFileForMavenPublication' because:
  Build cache is disabled
Task ':generatePomFileForMavenPublication' is not up-to-date because:
  Task is untracked because: Gradle doesn't understand the data structures used to configure this task
Resolve mutations for :generatePomFileForNebulaPublication (Thread[#314,Execution worker Thread 5,5,main]) started.
:generatePomFileForNebulaPublication (Thread[#314,Execution worker Thread 5,5,main]) started.

> Task :generatePomFileForNebulaPublication
Caching disabled for task ':generatePomFileForNebulaPublication' because:
  Build cache is disabled
Task ':generatePomFileForNebulaPublication' is not up-to-date because:
  Task is untracked because: Gradle doesn't understand the data structures used to configure this task
Resolve mutations for :generatePomFileForPluginZipPublication (Thread[#314,Execution worker Thread 5,5,main]) started.
:generatePomFileForPluginZipPublication (Thread[#314,Execution worker Thread 5,5,main]) started.

> Task :generatePomFileForPluginZipPublication
Caching disabled for task ':generatePomFileForPluginZipPublication' because:
  Build cache is disabled
Task ':generatePomFileForPluginZipPublication' is not up-to-date because:
  Task is untracked because: Gradle doesn't understand the data structures used to configure this task
Resolve mutations for :validateMavenPom (Thread[#309,included builds,5,main]) started.
:validateMavenPom (Thread[#309,included builds,5,main]) started.

> Task :validateMavenPom
Caching disabled for task ':validateMavenPom' because:
  Build cache is disabled
Task ':validateMavenPom' is not up-to-date because:
  No history is available.
groupId with value org.opensearch.plugin is validated.
artifactId with value opensearch-security is validated.
version with value 3.0.0.0-SNAPSHOT is validated.
name with value opensearch-security is validated.
description with value Provide access control related features for OpenSearch is validated.
url with value https://github.com/opensearch-project/security is validated.
licenses.name with value The Apache License, Version 2.0 is validated.
licenses.url with value http://www.apache.org/licenses/LICENSE-2.0.txt is validated.
developers.name with value OpenSearch is validated.
developers.url with value https://github.com/opensearch-project/security is validated.
scm.url with value https://github.com/opensearch-project/security is validated.
Resolve mutations for :validateNebulaPom (Thread[#309,included builds,5,main]) started.
:validateNebulaPom (Thread[#309,included builds,5,main]) started.

> Task :validateNebulaPom
Caching disabled for task ':validateNebulaPom' because:
  Build cache is disabled
Task ':validateNebulaPom' is not up-to-date because:
  No history is available.
groupId with value org.opensearch.plugin is validated.
artifactId with value opensearch-security is validated.
version with value 3.0.0.0-SNAPSHOT is validated.
name with value opensearch-security is validated.
description with value Provide access control related features for OpenSearch is validated.
url with value https://github.com/opensearch-project/security is validated.
licenses.name with value The Apache License, Version 2.0 is validated.
licenses.url with value http://www.apache.org/licenses/LICENSE-2.0.txt is validated.
developers.name with value OpenSearch is validated.
developers.url with value https://github.com/opensearch-project/security is validated.
scm.url with value https://github.com/opensearch-project/security is validated.
Resolve mutations for :validatePluginZipPom (Thread[#309,included builds,5,main]) started.
:validatePluginZipPom (Thread[#309,included builds,5,main]) started.

> Task :validatePluginZipPom
Caching disabled for task ':validatePluginZipPom' because:
  Build cache is disabled
Task ':validatePluginZipPom' is not up-to-date because:
  No history is available.
groupId with value org.opensearch.plugin is validated.
artifactId with value opensearch-security is validated.
version with value 3.0.0.0-SNAPSHOT is validated.
name with value opensearch-security is validated.
description with value Provide access control related features for OpenSearch is validated.
url with value https://github.com/opensearch-project/security is validated.
licenses.name with value The Apache License, Version 2.0 is validated.
licenses.url with value http://www.apache.org/licenses/LICENSE-2.0.txt is validated.
developers.name with value OpenSearch is validated.
developers.url with value https://github.com/opensearch-project/security is validated.
scm.url with value https://github.com/opensearch-project/security is validated.
Resolve mutations for :validatePom (Thread[#309,included builds,5,main]) started.
:validatePom (Thread[#309,included builds,5,main]) started.

> Task :validatePom
Skipping task ':validatePom' as it has no actions.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.5/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 7s
6 actionable tasks: 6 executed
Watched directory hierarchies: [/Users/zelinhao/workplace/security]

Related Issues

Regarding of the breaking change to security plugin.
#12807 (comment)

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2024-03-22T21:31:42Z

❌ Gradle check result for 94f90f7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

cwperks · 2024-03-22T21:39:23Z

TY @zelinh !

CHANGELOG.md

github-actions · 2024-03-22T21:41:36Z

Compatibility status:

Checks if related components are compatible with change 20bfd85

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

github-actions · 2024-03-22T22:01:10Z

❌ Gradle check result for 10e2669: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-03-22T22:16:35Z

✅ Gradle check result for f553e19: SUCCESS

github-actions · 2024-03-22T22:54:46Z

❌ Gradle check result for 10e2669: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-03-22T23:49:33Z

❌ Gradle check result for 10e2669: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-03-23T00:55:04Z

❌ Gradle check result for 10e2669: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

reta · 2024-03-23T01:20:48Z

@zelinh could you please rebase against main? thank you

Signed-off-by: Zelin Hao <[email protected]>

github-actions · 2024-03-25T13:02:20Z

❕ Gradle check result for 20bfd85: UNSTABLE

TEST FAILURES:

      3 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

zelinh · 2024-03-25T17:30:30Z

Thanks @reta for the rebase here. I will create manual backport PR to 2.x branch.

…project#12876) * Change from configureEach to all to resolve incompatibility Signed-off-by: Zelin Hao <[email protected]> * Update Changelog Signed-off-by: Zelin Hao <[email protected]> --------- Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>

…project#12876) * Change from configureEach to all to resolve incompatibility Signed-off-by: Zelin Hao <[email protected]> * Update Changelog Signed-off-by: Zelin Hao <[email protected]> --------- Signed-off-by: Zelin Hao <[email protected]>

zelinh force-pushed the add-dependency-pomvalidate branch from 94f90f7 to 10e2669 Compare March 22, 2024 21:28

cwperks approved these changes Mar 22, 2024

View reviewed changes

cwperks reviewed Mar 22, 2024

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

zelinh mentioned this pull request Mar 22, 2024

Revert "Add explicit dependency to validatePom and generatePom tasks (#12807)" #12863

Closed

8 tasks

reta approved these changes Mar 22, 2024

View reviewed changes

reta mentioned this pull request Mar 23, 2024

[AUTO] Increment version to 2.14.0-SNAPSHOT opensearch-project/security#4154

Merged

zelinh added 2 commits March 25, 2024 08:07

Change from configureEach to all to resolve incompatibility

23a371e

Signed-off-by: Zelin Hao <[email protected]>

Update Changelog

20bfd85

Signed-off-by: Zelin Hao <[email protected]>

reta force-pushed the add-dependency-pomvalidate branch from 10e2669 to 20bfd85 Compare March 25, 2024 12:07

reta self-requested a review March 25, 2024 13:03

reta approved these changes Mar 25, 2024

View reviewed changes

reta merged commit 9267170 into opensearch-project:main Mar 25, 2024
31 checks passed

zelinh mentioned this pull request Mar 25, 2024

Backport to 2.x "Add explicit dependency to validatePom and generatePom tasks" #12909

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace configureEach with all for publication iteration #12876

Replace configureEach with all for publication iteration #12876

zelinh commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024

cwperks commented Mar 22, 2024

github-actions bot commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 23, 2024

reta commented Mar 23, 2024

github-actions bot commented Mar 25, 2024

zelinh commented Mar 25, 2024

Replace configureEach with all for publication iteration #12876

Replace configureEach with all for publication iteration #12876

Conversation

zelinh commented Mar 22, 2024 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Mar 22, 2024

cwperks commented Mar 22, 2024

github-actions bot commented Mar 22, 2024 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 23, 2024

reta commented Mar 23, 2024

github-actions bot commented Mar 25, 2024

zelinh commented Mar 25, 2024

zelinh commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024 •

edited

Loading