Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport 2.x] Added static setting for checkPendingFlushUpdate functionality of lucene index writer #12786

Merged

Conversation

CaptainDredge
Copy link
Contributor

Description

This PR backports changes done in PR #12710

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ene writer (opensearch-project#12710)

Signed-off-by: Prabhat Sharma <[email protected]>
Co-authored-by: Prabhat Sharma <[email protected]>
(cherry picked from commit c369ec4)
@CaptainDredge CaptainDredge force-pushed the backport/backport-12710-to-2.x branch from 6a39e8a to e337787 Compare March 20, 2024 12:22
@CaptainDredge CaptainDredge changed the title [backport 2.x] Added static setting for checkPendingFlushUpdate functionality of luc… [backport 2.x] Added static setting for checkPendingFlushUpdate functionality of lucene index writer Mar 20, 2024
Copy link
Contributor

❌ Gradle check result for 6a39e8a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Mar 20, 2024

Compatibility status:

Checks if related components are compatible with change e337787

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

✅ Gradle check result for e337787: SUCCESS

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.26%. Comparing base (0dd892c) to head (e337787).
Report is 56 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12786      +/-   ##
============================================
- Coverage     71.28%   71.26%   -0.02%     
- Complexity    60145    60310     +165     
============================================
  Files          4957     4972      +15     
  Lines        282799   283766     +967     
  Branches      41409    41497      +88     
============================================
+ Hits         201591   202224     +633     
- Misses        64189    64477     +288     
- Partials      17019    17065      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 29bcc48 into opensearch-project:2.x Mar 20, 2024
31 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.13 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.13 2.13
# Navigate to the new working tree
pushd ../.worktrees/backport-2.13
# Create a new branch
git switch --create backport/backport-12786-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 29bcc484974c9eb1cbec938dd379ffe3e1de695d
# Push it to GitHub
git push --set-upstream origin backport/backport-12786-to-2.13
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.13

Then, create a pull request where the base branch is 2.13 and the compare/head branch is backport/backport-12786-to-2.13.

CaptainDredge added a commit to CaptainDredge/OpenSearch that referenced this pull request Mar 22, 2024
…ene writer (opensearch-project#12710) (opensearch-project#12786)

Signed-off-by: Prabhat Sharma <[email protected]>
Co-authored-by: Prabhat Sharma <[email protected]>
(cherry picked from commit c369ec4)
(cherry picked from commit 29bcc48)
CaptainDredge added a commit to CaptainDredge/OpenSearch that referenced this pull request Mar 22, 2024
…ene writer (opensearch-project#12710) (opensearch-project#12786)

Signed-off-by: Prabhat Sharma <[email protected]>
Co-authored-by: Prabhat Sharma <[email protected]>
(cherry picked from commit c369ec4)
(cherry picked from commit 29bcc48)
Signed-off-by: Prabhat Sharma <[email protected]>
CaptainDredge added a commit to CaptainDredge/OpenSearch that referenced this pull request Mar 22, 2024
…ene writer (opensearch-project#12710) (opensearch-project#12786)

Signed-off-by: Prabhat Sharma <[email protected]>
Co-authored-by: Prabhat Sharma <[email protected]>
(cherry picked from commit c369ec4)
(cherry picked from commit 29bcc48)
Signed-off-by: Prabhat Sharma <[email protected]>
reta pushed a commit that referenced this pull request Mar 22, 2024
…ene writer (#12710) (#12786) (#12857)

(cherry picked from commit c369ec4)
(cherry picked from commit 29bcc48)

Signed-off-by: Prabhat Sharma <[email protected]>
Co-authored-by: Prabhat Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants