[Bug Fix] Fix issue where wrong shard blob files are picked up for del… #12701
Conversation
…etion. Signed-off-by: Harish Bhakuni <[email protected]>
Compatibility status:Checks if related components are compatible with change 49b13b0 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git] |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12701 +/- ##
============================================
+ Coverage 71.42% 71.52% +0.10%
- Complexity 59978 60160 +182
============================================
Files 4985 4992 +7
Lines 282275 282725 +450
Branches 40946 41003 +57
============================================
+ Hits 201603 202219 +616
+ Misses 63999 63737 -262
- Partials 16673 16769 +96 ☔ View full report in Codecov by Sentry. |
harishbhakuni
requested review from
abbashus,
adnapibar,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Show resolved
Hide resolved
…p for shallow snapshot deletion. (#12701) Signed-off-by: Harish Bhakuni <[email protected]> (cherry picked from commit 48004ee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…p for shallow snapshot deletion. (#12701) (#12703) (cherry picked from commit 48004ee) Signed-off-by: Harish Bhakuni <[email protected]>
…p for shallow snapshot deletion. (opensearch-project#12701) Signed-off-by: Harish Bhakuni <[email protected]>
…p for shallow snapshot deletion. (opensearch-project#12701) Signed-off-by: Harish Bhakuni <[email protected]>
…p for shallow snapshot deletion. (opensearch-project#12701) Signed-off-by: Harish Bhakuni <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
…etion.
Description
We recently fixed a
Avoid String out of bound error during snapshot deletein #12337, where another bug got introduced due to which it is picking wrong shard blobs during deletion.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
New functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.