Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Tracing for deep search path (#12103) #12646

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

dzane17
Copy link
Contributor

@dzane17 dzane17 commented Mar 13, 2024

  • Tracing for deep search path

Signed-off-by: David Zane [email protected]

  • Refactor search phase tracing instrumentation to detach span creation from the SearchRequestOperationsListener

Signed-off-by: Andriy Redko [email protected]

  • Close WrappedPhase span

Signed-off-by: David Zane [email protected]

  • Add asserting listener class

Signed-off-by: David Zane [email protected]

  • Cleanup AbstractSearchAsyncActionTests tests

Signed-off-by: Andriy Redko [email protected]

  • Cleanup SearchAsyncActionTests tests

Signed-off-by: Andriy Redko [email protected]

  • Cleanup CanMatchPreFilterSearchPhaseTests tests

Signed-off-by: Andriy Redko [email protected]


Signed-off-by: David Zane [email protected]
Signed-off-by: Andriy Redko [email protected]
Co-authored-by: Andriy Redko [email protected]
(cherry picked from commit 77a1193)

Description

2.x Backport for #12103

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Tracing for deep search path

Signed-off-by: David Zane <[email protected]>

* Refactor search phase tracing instrumentation to detach span creation from the SearchRequestOperationsListener

Signed-off-by: Andriy Redko <[email protected]>

* Close WrappedPhase span

Signed-off-by: David Zane <[email protected]>

* Add asserting listener class

Signed-off-by: David Zane <[email protected]>

* Cleanup AbstractSearchAsyncActionTests tests

Signed-off-by: Andriy Redko <[email protected]>

* Cleanup SearchAsyncActionTests tests

Signed-off-by: Andriy Redko <[email protected]>

* Cleanup CanMatchPreFilterSearchPhaseTests tests

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: David Zane <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
(cherry picked from commit 77a1193)
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change cea6285

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❕ Gradle check result for cea6285: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads
      1 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta reta merged commit a5f335f into opensearch-project:2.x Mar 13, 2024
95 checks passed
@reta reta added the v2.13.0 Issues and PRs related to version 2.13.0 label Mar 13, 2024
@dzane17 dzane17 deleted the backport/backport-12103-to-2.x branch March 13, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.13.0 Issues and PRs related to version 2.13.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants