-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate IO Based AdmissionController to AdmissionControl Framework #12583
Integrate IO Based AdmissionController to AdmissionControl Framework #12583
Conversation
e551547
to
b0f31ea
Compare
Compatibility status:Checks if related components are compatible with change 4626c01 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for e551547: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b0f31ea: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
93ee481
to
7a0519c
Compare
❌ Gradle check result for 93ee481: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 7a0519c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
7a0519c
to
d6c1b85
Compare
❕ Gradle check result for d6c1b85: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12583 +/- ##
============================================
- Coverage 71.42% 71.33% -0.09%
- Complexity 59978 60017 +39
============================================
Files 4985 4988 +3
Lines 282275 282490 +215
Branches 40946 40980 +34
============================================
- Hits 201603 201504 -99
- Misses 63999 64253 +254
- Partials 16673 16733 +60 ☔ View full report in Codecov by Sentry. |
…pensearch-project#12583) * Integrated IO Based AdmissionController to AdmissionControl Framework Signed-off-by: Ajay Kumar Movva <[email protected]> * Integration Tests Fixes to Add Delay for Trackers Update Signed-off-by: Ajay Kumar Movva <[email protected]> * Fixing Integ Test and Removed Multi Node Tests Signed-off-by: Ajay Kumar Movva <[email protected]> * Addressing Comments Signed-off-by: Ajay Kumar Movva <[email protected]> --------- Signed-off-by: Ajay Kumar Movva <[email protected]> Co-authored-by: Ajay Kumar Movva <[email protected]>
…pensearch-project#12583) Signed-off-by: Ajay Kumar Movva <[email protected]>
…12583) (#12659) Signed-off-by: Ajay Kumar Movva <[email protected]>
…amework (opensearch-project#12583)" This reverts commit b6b16d8. Reverting as this introduced test failures detailed in opensearch-project#12664.
…amework (opensearch-project#12583)" This reverts commit b6b16d8. Reverting as this introduced test failures detailed in opensearch-project#12664. Signed-off-by: Andrew Ross <[email protected]>
@@ -19,6 +19,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
- Remote reindex: Add support for configurable retry mechanism ([#12561](https://github.com/opensearch-project/OpenSearch/pull/12561)) | |||
- [Admission Control] Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats ([#11880](https://github.com/opensearch-project/OpenSearch/pull/11880)) | |||
- Tracing for deep search path ([#12103](https://github.com/opensearch-project/OpenSearch/pull/12103)) | |||
- [Admission Control] Integrated IO Based AdmissionController to AdmissionControl Framework ([#12583](https://github.com/opensearch-project/OpenSearch/pull/12583)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, your changelog entry is in the wrong section, hence the cherry-pick failure on the backport.
…amework (opensearch-project#12583) (opensearch-project#12659)" This reverts commit 3970ec4. Reverting as this introduced test failures detailed in opensearch-project#12664. Signed-off-by: Andrew Ross <[email protected]>
…amework (#12583)" (#12670) This reverts commit b6b16d8. Reverting as this introduced test failures detailed in #12664. Signed-off-by: Andrew Ross <[email protected]>
…pensearch-project#12583) * Integrated IO Based AdmissionController to AdmissionControl Framework Signed-off-by: Ajay Kumar Movva <[email protected]> * Integration Tests Fixes to Add Delay for Trackers Update Signed-off-by: Ajay Kumar Movva <[email protected]> * Fixing Integ Test and Removed Multi Node Tests Signed-off-by: Ajay Kumar Movva <[email protected]> * Addressing Comments Signed-off-by: Ajay Kumar Movva <[email protected]> --------- Signed-off-by: Ajay Kumar Movva <[email protected]> Co-authored-by: Ajay Kumar Movva <[email protected]>
…pensearch-project#12583) * Integrated IO Based AdmissionController to AdmissionControl Framework Signed-off-by: Ajay Kumar Movva <[email protected]> * Integration Tests Fixes to Add Delay for Trackers Update Signed-off-by: Ajay Kumar Movva <[email protected]> * Fixing Integ Test and Removed Multi Node Tests Signed-off-by: Ajay Kumar Movva <[email protected]> * Addressing Comments Signed-off-by: Ajay Kumar Movva <[email protected]> --------- Signed-off-by: Ajay Kumar Movva <[email protected]> Co-authored-by: Ajay Kumar Movva <[email protected]>
…pensearch-project#12583) * Integrated IO Based AdmissionController to AdmissionControl Framework Signed-off-by: Ajay Kumar Movva <[email protected]> * Integration Tests Fixes to Add Delay for Trackers Update Signed-off-by: Ajay Kumar Movva <[email protected]> * Fixing Integ Test and Removed Multi Node Tests Signed-off-by: Ajay Kumar Movva <[email protected]> * Addressing Comments Signed-off-by: Ajay Kumar Movva <[email protected]> --------- Signed-off-by: Ajay Kumar Movva <[email protected]> Co-authored-by: Ajay Kumar Movva <[email protected]>
…pensearch-project#12583) * Integrated IO Based AdmissionController to AdmissionControl Framework Signed-off-by: Ajay Kumar Movva <[email protected]> * Integration Tests Fixes to Add Delay for Trackers Update Signed-off-by: Ajay Kumar Movva <[email protected]> * Fixing Integ Test and Removed Multi Node Tests Signed-off-by: Ajay Kumar Movva <[email protected]> * Addressing Comments Signed-off-by: Ajay Kumar Movva <[email protected]> --------- Signed-off-by: Ajay Kumar Movva <[email protected]> Co-authored-by: Ajay Kumar Movva <[email protected]>
…12702) * Integrate IO Based AdmissionController to AdmissionControl Framework (#12583) --------- Signed-off-by: Ajay Kumar Movva <[email protected]> Co-authored-by: Ajay Kumar Movva <[email protected]>
…pensearch-project#12702) * Integrate IO Based AdmissionController to AdmissionControl Framework (opensearch-project#12583) --------- Signed-off-by: Ajay Kumar Movva <[email protected]> Co-authored-by: Ajay Kumar Movva <[email protected]>
…pensearch-project#12583) * Integrated IO Based AdmissionController to AdmissionControl Framework Signed-off-by: Ajay Kumar Movva <[email protected]> * Integration Tests Fixes to Add Delay for Trackers Update Signed-off-by: Ajay Kumar Movva <[email protected]> * Fixing Integ Test and Removed Multi Node Tests Signed-off-by: Ajay Kumar Movva <[email protected]> * Addressing Comments Signed-off-by: Ajay Kumar Movva <[email protected]> --------- Signed-off-by: Ajay Kumar Movva <[email protected]> Co-authored-by: Ajay Kumar Movva <[email protected]>
…amework (opensearch-project#12583)" (opensearch-project#12670) This reverts commit b6b16d8. Reverting as this introduced test failures detailed in opensearch-project#12664. Signed-off-by: Andrew Ross <[email protected]>
…pensearch-project#12702) * Integrate IO Based AdmissionController to AdmissionControl Framework (opensearch-project#12583) --------- Signed-off-by: Ajay Kumar Movva <[email protected]> Co-authored-by: Ajay Kumar Movva <[email protected]>
…pensearch-project#12583) * Integrated IO Based AdmissionController to AdmissionControl Framework Signed-off-by: Ajay Kumar Movva <[email protected]> * Integration Tests Fixes to Add Delay for Trackers Update Signed-off-by: Ajay Kumar Movva <[email protected]> * Fixing Integ Test and Removed Multi Node Tests Signed-off-by: Ajay Kumar Movva <[email protected]> * Addressing Comments Signed-off-by: Ajay Kumar Movva <[email protected]> --------- Signed-off-by: Ajay Kumar Movva <[email protected]> Co-authored-by: Ajay Kumar Movva <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
…amework (opensearch-project#12583)" (opensearch-project#12670) This reverts commit b6b16d8. Reverting as this introduced test failures detailed in opensearch-project#12664. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
…pensearch-project#12702) * Integrate IO Based AdmissionController to AdmissionControl Framework (opensearch-project#12583) --------- Signed-off-by: Ajay Kumar Movva <[email protected]> Co-authored-by: Ajay Kumar Movva <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Integrated IO Based AdmissionController to AdmissionControl Framework.
Node Stats Output On Linux
Node Stats Output On Mac
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.