Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Migration] Changes for Primary Relocation during migration #12494

Merged
merged 14 commits into from
Mar 21, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Feb 29, 2024

Description

Allows relocation from docrep primary to remote primary and remote primary to remote primary .

This also seeds remote store while moving from docrep to primary .

Related Issues

Resolves #12689

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gbbafna gbbafna changed the title [Remote Store Migration] Changes for Primary Relocation during migration [Remote Migration] Changes for Primary Relocation during migration Feb 29, 2024
Copy link
Contributor

github-actions bot commented Feb 29, 2024

Compatibility status:

Checks if related components are compatible with change 5601758

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for d4fce02: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need changes behind a Feature flag?

@gbbafna
Copy link
Collaborator Author

gbbafna commented Mar 4, 2024

Do we need changes behind a Feature flag?

The mixed mode is already behind a feature flag . So by virtue of that most of the risky code is already under feature flag .

Copy link
Contributor

github-actions bot commented Mar 4, 2024

❌ Gradle check result for 9cb67fc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 463eb84: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 77c9b3a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna gbbafna marked this pull request as ready for review March 15, 2024 08:39
@sachinpkale
Copy link
Member

Flaky test is discussed here: #12338 and not related to changes in this PR.

Copy link
Contributor

❌ Gradle check result for cf5dc23: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 5601758: SUCCESS

@sachinpkale sachinpkale merged commit f3d2bee into opensearch-project:main Mar 21, 2024
29 of 30 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Mar 21, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12494-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f3d2beee637f63e38c8f26dbcee9f2a82f9c87b6
# Push it to GitHub
git push --set-upstream origin backport/backport-12494-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12494-to-2.x.

gbbafna added a commit to gbbafna/OpenSearch that referenced this pull request Mar 21, 2024
…pensearch-project#12494)

Changes for Primary Relocation during migration

---------

Signed-off-by: Gaurav Bafna <[email protected]>
sachinpkale pushed a commit that referenced this pull request Mar 22, 2024
…12494) (#12816)

Changes for Primary Relocation during migration

---------

Signed-off-by: Gaurav Bafna <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…pensearch-project#12494)

Changes for Primary Relocation during migration

---------

Signed-off-by: Gaurav Bafna <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request skip-changelog Storage:Durability Issues and PRs related to the durability framework
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Remote Store Migration] Relocation of primary shards from doc rep to remote store node
4 participants