Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline ingest processor supports ignore_missing_pipeline parameter #12476

Closed
wants to merge 3 commits into from

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Feb 27, 2024

Description

This PR introduces a new parameter ignore_missing_pipeline for the pipeline ingest processor, when the parameter is true and the specified pipeline name doesn't exist, that processor exits quietly without throwing exception.

This enhancement can avoid indexing failures when the referenced pipeline is deleted suddenly, and can also let users create the referenced pipeline later than the current pipeline, as the example below, if the inner pipeline hasn't been created, the outer pipeline works well with setting ignore_missing_pipeline to true, sometimes users want the inner pipeline to execute at some point, when the inner pipeline is created later, it will be executed, and after it is deleted, the outer pipeline still works well:

PUT _ingest/pipeline/outer
{
  "description": "outer pipeline",
  "processors": [
    {
      "pipeline": {
        "name": "inner",
        "ignore_missing_pipeline": true
      }
    },
    {
      "set": {
        "field": "foo",
        "value": "{{bar}}"
      }
    }
  ]
}

Related Issues

#12463

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Gao Binlong <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 27, 2024

Compatibility status:

Checks if related components are compatible with change 20fffb9

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for b42da9b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for bf9b67a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 20fffb9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should take this change.

referenced pipeline is deleted suddenly

If this happens, this sounds like it should be part of application logic where the calling client should alter the pipelines associated with a request so it does not fail.

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Mar 30, 2024
@gaobinlong
Copy link
Collaborator Author

I don't think we should take this change.

referenced pipeline is deleted suddenly

If this happens, this sounds like it should be part of application logic where the calling client should alter the pipelines associated with a request so it does not fail.

Thank you, all right, this PR can hold on unless more users request for it, close this PR for now.

@gaobinlong gaobinlong closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalled Issues that have stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants