-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new write_only_allow_delete indexing block #12385
Conversation
Signed-off-by: Gaurav Chandani <[email protected]>
Signed-off-by: Gaurav Chandani <[email protected]>
Signed-off-by: Gaurav Chandani <[email protected]>
Compatibility status:Checks if related components are compatible with change 987dfa9 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for 987dfa9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@@ -461,7 +471,8 @@ public enum APIBlock implements Writeable { | |||
READ("read", INDEX_READ_BLOCK), | |||
WRITE("write", INDEX_WRITE_BLOCK), | |||
METADATA("metadata", INDEX_METADATA_BLOCK), | |||
READ_ONLY_ALLOW_DELETE("read_only_allow_delete", INDEX_READ_ONLY_ALLOW_DELETE_BLOCK); | |||
READ_ONLY_ALLOW_DELETE("read_only_allow_delete", INDEX_READ_ONLY_ALLOW_DELETE_BLOCK), | |||
WRITE_ONLY_ALLOW_DELETE("write_only_allow_delete", INDEX_WRITE_ONLY_ALLOW_DELETE_BLOCK); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of our blocks are currently inconsistent (e.g. APIBlock.READ
blocks reads as one might expect, yet APIBlock.READ_ONLY
blocks writes). However, making something named WRITE_ONLY_ALLOW_DELETE
be functionally identical to something named READ_ONLY_ALLOW_DELETE
doesn't seem to be helping the situation. Given the inconsistency already present, I don't have an obvious alternative suggestion, but can we try to work through a better name if we go forward with this approach?
This PR is stalled because it has been open for 30 days with no activity. |
There is no plan to take this forward. Closing it for now. |
Description
Added a new
write_only_allow_delete
block for indices.This was proposed here: #12362
[Describe what this change achieves]
This will allow user to manually add block that has similar permissions as
read_only_allow_delete
block, sinceread_only_allow_delete
is used only for internal purposesRelated Issues
Resolves : #12362
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.