Adds latency metrics for ClusterState Appliers and Listeners #12333

gargharsh3134 · 2024-02-15T04:29:08Z

Description

Publish Otel Histogram type metrics to track latencies of:

ClusterState Appliers: cluster.state.appliers.latency in ms with dimension Operation as the invoking applier.
ClusterState Listeners: cluster.state.listeners.latency in ms with dimension Operation as the invoking listener.
Reroute: allocation.reroute.latency in ms.
ClusterState Computation: cluster.state.new.compute.latency in ms with dimension Operation as the invoking taskExecutor.
ClusterState Publishing: cluster.state.publish.success.latency in ms.

Related Issues

Resolves #[12332]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2024-02-15T04:50:53Z

Compatibility status:

Checks if related components are compatible with change 985b048

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

github-actions · 2024-02-15T05:17:17Z

✅ Gradle check result for d29b1cd: SUCCESS

codecov · 2024-02-15T05:17:55Z

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.39%. Comparing base (b15cb0c) to head (985b048).
Report is 291 commits behind head on main.

❗ Current head 985b048 differs from pull request most recent head d1fd5c6

Please upload reports for the commit d1fd5c6 to get more accurate results.

Files	Patch %	Lines
server/src/main/java/org/opensearch/node/Node.java	72.72%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12333      +/-   ##
============================================
- Coverage     71.42%   71.39%   -0.03%     
- Complexity    59978    60284     +306     
============================================
  Files          4985     5011      +26     
  Lines        282275   283693    +1418     
  Branches      40946    41117     +171     
============================================
+ Hits         201603   202543     +940     
- Misses        63999    64373     +374     
- Partials      16673    16777     +104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

server/src/main/java/org/opensearch/cluster/service/ClusterApplierService.java

...test/java/org/opensearch/action/bulk/TransportBulkActionIndicesThatCannotBeCreatedTests.java

server/src/test/java/org/opensearch/action/bulk/TransportBulkActionIngestTests.java

test/framework/src/main/java/org/opensearch/test/ClusterServiceUtils.java

github-actions · 2024-03-01T05:36:35Z

❌ Gradle check result for ac76c80: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-03-01T05:41:06Z

❌ Gradle check result for edc7ff8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

server/src/main/java/org/opensearch/node/Node.java

amkhar · 2024-03-01T11:55:54Z

@gargharsh3134 - please add testing details.
And see if any unit tests needs to be added to assert that those telemetry data is being recorded properly or not ?

Gaganjuneja · 2024-03-10T05:17:36Z

Let's finish this PR. So that we can pick this change as well in the performance testing. Thanks!

github-actions · 2024-03-14T11:23:28Z

❌ Gradle check result for 9e01686: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-05-15T12:49:22Z

❌ Gradle check result for 3f8acdd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

server/src/main/java/org/opensearch/cluster/routing/allocation/AllocationService.java

server/src/main/java/org/opensearch/cluster/ClusterManagerMetrics.java

Signed-off-by: Harsh Garg <[email protected]>

github-actions · 2024-05-16T10:20:01Z

❌ Gradle check result for d1fd5c6: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

rajiv-kv

LGTM.

sachinpkale · 2024-05-20T06:18:11Z

Re-triggering the gradle build

github-actions · 2024-05-20T07:13:58Z

✅ Gradle check result for d1fd5c6: SUCCESS

sachinpkale · 2024-05-20T12:42:56Z

@gargharsh3134 Can you check why these Gradle Assemble tasks are failing?

* Adds latency metrics for ClusterState Appliers and Listeners Signed-off-by: Harsh Garg <[email protected]> (cherry picked from commit a254aa9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…art of opensearch-project#12333 Signed-off-by: Harsh Garg <[email protected]>

…art of #12333 (#13926) * Retaining the old constructors for classes marked as API changed as part of #12333 --------- Signed-off-by: Harsh Garg <[email protected]> Co-authored-by: Harsh Garg <[email protected]>

…rch-project#12333) * Adds latency metrics for ClusterState Appliers and Listeners Signed-off-by: Harsh Garg <[email protected]>

…art of opensearch-project#12333 (opensearch-project#13926) * Retaining the old constructors for classes marked as API changed as part of opensearch-project#12333 --------- Signed-off-by: Harsh Garg <[email protected]> Co-authored-by: Harsh Garg <[email protected]>

…rch-project#12333) * Adds latency metrics for ClusterState Appliers and Listeners Signed-off-by: Harsh Garg <[email protected]>

…art of opensearch-project#12333 (opensearch-project#13926) * Retaining the old constructors for classes marked as API changed as part of opensearch-project#12333 --------- Signed-off-by: Harsh Garg <[email protected]> Co-authored-by: Harsh Garg <[email protected]>

…rch-project#12333) * Adds latency metrics for ClusterState Appliers and Listeners Signed-off-by: Harsh Garg <[email protected]>

…art of opensearch-project#12333 (opensearch-project#13926) * Retaining the old constructors for classes marked as API changed as part of opensearch-project#12333 --------- Signed-off-by: Harsh Garg <[email protected]> Co-authored-by: Harsh Garg <[email protected]>

amkhar reviewed Feb 23, 2024

View reviewed changes

server/src/main/java/org/opensearch/cluster/service/ClusterApplierService.java Show resolved Hide resolved

Gaganjuneja reviewed Feb 25, 2024

View reviewed changes

server/src/main/java/org/opensearch/cluster/service/ClusterApplierService.java Outdated Show resolved Hide resolved

Gaganjuneja reviewed Feb 25, 2024

View reviewed changes

gargharsh3134 force-pushed the csaLatencies branch 2 times, most recently from ac76c80 to edc7ff8 Compare March 1, 2024 05:12

Gaganjuneja reviewed Mar 1, 2024

View reviewed changes

server/src/main/java/org/opensearch/node/Node.java Show resolved Hide resolved

gargharsh3134 mentioned this pull request Mar 15, 2024

Adds counter metrics for leader and follower check failures #12439

Merged

8 tasks

gargharsh3134 marked this pull request as ready for review March 15, 2024 09:02

gargharsh3134 requested review from abbashus, adnapibar, anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, dbwiddis, dreamer-89, gbbafna, kotwanikunal, mch2, msfroh and nknize as code owners March 15, 2024 09:02

rajiv-kv reviewed May 16, 2024

View reviewed changes

server/src/main/java/org/opensearch/cluster/routing/allocation/AllocationService.java Outdated Show resolved Hide resolved

shwetathareja reviewed May 16, 2024

View reviewed changes

server/src/main/java/org/opensearch/cluster/ClusterManagerMetrics.java Show resolved Hide resolved

server/src/main/java/org/opensearch/cluster/ClusterManagerMetrics.java Outdated Show resolved Hide resolved

Harsh Garg added 2 commits May 16, 2024 15:12

Adding opensearch.internal annotation and marking methods non-static

f2c4b85

Signed-off-by: Harsh Garg <[email protected]>

Merge branch 'main' into csaLatencies

d1fd5c6

Signed-off-by: Harsh Garg <[email protected]>

rajiv-kv approved these changes May 16, 2024

View reviewed changes

sachinpkale added the backport 2.x Backport to 2.x branch label May 20, 2024

sachinpkale approved these changes May 20, 2024

View reviewed changes

sachinpkale merged commit a254aa9 into opensearch-project:main May 20, 2024
29 of 36 checks passed

opensearch-trigger-bot bot mentioned this pull request May 20, 2024

[Backport 2.x] Adds latency metrics for ClusterState Appliers and Listeners #13755

Closed

gargharsh3134 pushed a commit to gargharsh3134/OpenSearch that referenced this pull request Jun 3, 2024

Retaining the old constructors for classes marked as API changed as p…

3028db6

…art of opensearch-project#12333 Signed-off-by: Harsh Garg <[email protected]>

This was referenced Jun 3, 2024

Retaining the old constructors for classes marked as API changed as part of #12333 #13926

Merged

[BUG] Constructors Incompatibility of API classes. #14068

Closed

This was referenced Jun 10, 2024

Retaining old constructor of MasterService class to maintain compatib… #14123

Merged

[Backport] ClusterManager metrics instrumentation changes #14118

Merged

finnegancarroll mentioned this pull request Jun 14, 2024

Remove composeBuild fixture tasks when docker support not found #14357

Merged

3 tasks

BrewTestBot mentioned this pull request Jun 26, 2024

opensearch 2.15.0 Homebrew/homebrew-core#175637

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds latency metrics for ClusterState Appliers and Listeners #12333

Adds latency metrics for ClusterState Appliers and Listeners #12333

gargharsh3134 commented Feb 15, 2024 •

edited

Loading

github-actions bot commented Feb 15, 2024 •

edited

Loading

github-actions bot commented Feb 15, 2024

codecov bot commented Feb 15, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024

github-actions bot commented Mar 1, 2024

amkhar commented Mar 1, 2024

Gaganjuneja commented Mar 10, 2024

github-actions bot commented Mar 14, 2024

github-actions bot commented May 15, 2024

github-actions bot commented May 16, 2024

rajiv-kv left a comment

sachinpkale commented May 20, 2024

github-actions bot commented May 20, 2024

sachinpkale commented May 20, 2024

Adds latency metrics for ClusterState Appliers and Listeners #12333

Adds latency metrics for ClusterState Appliers and Listeners #12333

Conversation

gargharsh3134 commented Feb 15, 2024 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Feb 15, 2024 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Feb 15, 2024

codecov bot commented Feb 15, 2024 • edited Loading

Codecov Report

github-actions bot commented Mar 1, 2024

github-actions bot commented Mar 1, 2024

amkhar commented Mar 1, 2024

Gaganjuneja commented Mar 10, 2024

github-actions bot commented Mar 14, 2024

github-actions bot commented May 15, 2024

github-actions bot commented May 16, 2024

rajiv-kv left a comment

Choose a reason for hiding this comment

sachinpkale commented May 20, 2024

github-actions bot commented May 20, 2024

sachinpkale commented May 20, 2024

gargharsh3134 commented Feb 15, 2024 •

edited

Loading

github-actions bot commented Feb 15, 2024 •

edited

Loading

codecov bot commented Feb 15, 2024 •

edited

Loading