-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Add random replication strategy #12297
[Segment Replication] Add random replication strategy #12297
Conversation
Signed-off-by: Rishikesh1159 <[email protected]>
…Rishikesh1159/OpenSearch into Add_Random_Replication_Strategy
Signed-off-by: Rishikesh1159 <[email protected]>
Compatibility status:Checks if related components are compatible with change 6951ea2 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git] |
❕ Gradle check result for ba618e2: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12297 +/- ##
============================================
+ Coverage 71.41% 71.44% +0.03%
- Complexity 59813 59863 +50
============================================
Files 4959 4959
Lines 281126 281126
Branches 40857 40857
============================================
+ Hits 200753 200847 +94
+ Misses 63731 63639 -92
+ Partials 16642 16640 -2 ☔ View full report in Codecov by Sentry. |
test/framework/src/main/java/org/opensearch/test/OpenSearchIntegTestCase.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rishikesh1159 <[email protected]>
❕ Gradle check result for 6951ea2: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
* Add new method to pick a random replication strategy. Signed-off-by: Rishikesh1159 <[email protected]> * replace usage of refresh with refreshandWaitForReplication() Signed-off-by: Rishikesh1159 <[email protected]> * Add replication strategy logging. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> (cherry picked from commit f8225ca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add new method to pick a random replication strategy. * replace usage of refresh with refreshandWaitForReplication() * Add replication strategy logging. --------- (cherry picked from commit f8225ca) Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ject#12297) * Add new method to pick a random replication strategy. Signed-off-by: Rishikesh1159 <[email protected]> * replace usage of refresh with refreshandWaitForReplication() Signed-off-by: Rishikesh1159 <[email protected]> * Add replication strategy logging. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]>
…ject#12297) * Add new method to pick a random replication strategy. Signed-off-by: Rishikesh1159 <[email protected]> * replace usage of refresh with refreshandWaitForReplication() Signed-off-by: Rishikesh1159 <[email protected]> * Add replication strategy logging. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Aman Khare <[email protected]>
…ject#12297) * Add new method to pick a random replication strategy. Signed-off-by: Rishikesh1159 <[email protected]> * replace usage of refresh with refreshandWaitForReplication() Signed-off-by: Rishikesh1159 <[email protected]> * Add replication strategy logging. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]>
…ject#12297) * Add new method to pick a random replication strategy. Signed-off-by: Rishikesh1159 <[email protected]> * replace usage of refresh with refreshandWaitForReplication() Signed-off-by: Rishikesh1159 <[email protected]> * Add replication strategy logging. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This PR enables the support of random replication strategy for integration tests. This helps to increase the segment replication test coverage by randomly selecting replication strategy for tests not critical of replication strategy.
Related Issues
Resolves #12261
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.