Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of special WrappingSearchAsyncActionPhase so the onPhaseStart() will always be followed by onPhaseEnd() within AbstractSearchAsyncAction #12293

Merged
merged 3 commits into from
Feb 16, 2024

Merge branch 'main' into fix.phase.callback

a231a63
Select commit
Loading
Failed to load commit list.
Merged

Add support of special WrappingSearchAsyncActionPhase so the onPhaseStart() will always be followed by onPhaseEnd() within AbstractSearchAsyncAction #12293

Merge branch 'main' into fix.phase.callback
a231a63
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 14, 2024 in 1s

71.36% (target 70.00%)

View this Pull Request on Codecov

71.36% (target 70.00%)

Details

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bff8eb7) 71.49% compared to head (a231a63) 71.36%.

Files Patch % Lines
.../action/search/WrappingSearchAsyncActionPhase.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12293      +/-   ##
============================================
- Coverage     71.49%   71.36%   -0.14%     
+ Complexity    59859    59793      -66     
============================================
  Files          4959     4960       +1     
  Lines        281129   281130       +1     
  Branches      40857    40858       +1     
============================================
- Hits         201003   200636     -367     
- Misses        63425    63818     +393     
+ Partials      16701    16676      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.