Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.12] [Backport 2.x] Apply the fast filter optimization to composite aggregation #12283

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 6ed7565 from #11914.

…11914)

We can do efficient DateHistogram aggregation under composite
aggregations.

---------

(cherry picked from commit d5a6f99)

Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 6ed7565)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 64da1c0

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (3ff62da) 71.20% compared to head (64da1c0) 71.12%.

Files Patch % Lines
...h/aggregations/bucket/FastFilterRewriteHelper.java 87.40% 4 Missing and 13 partials ⚠️
...egations/bucket/composite/CompositeAggregator.java 88.37% 3 Missing and 2 partials ⚠️
...gregations/bucket/composite/InternalComposite.java 0.00% 2 Missing ⚠️
...ions/bucket/histogram/DateHistogramAggregator.java 84.61% 0 Missing and 2 partials ⚠️
.../bucket/histogram/AutoDateHistogramAggregator.java 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.12   #12283      +/-   ##
============================================
- Coverage     71.20%   71.12%   -0.09%     
  Complexity    59874    59874              
============================================
  Files          4939     4939              
  Lines        281664   281747      +83     
  Branches      41237    41259      +22     
============================================
- Hits         200571   200399     -172     
- Misses        64144    64401     +257     
+ Partials      16949    16947       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 64da1c0: ABORTED

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 64da1c0: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@msfroh msfroh merged commit eafa416 into 2.12 Feb 10, 2024
79 checks passed
@github-actions github-actions bot deleted the backport/backport-11914-to-2.12 branch February 10, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant