Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Searchable Snapshot] Fix bug of Searchable Snapshot Dependency on repository chunk_size #12277

Merged

Conversation

Rishikesh1159
Copy link
Member

@Rishikesh1159 Rishikesh1159 commented Feb 9, 2024

Description

This PR is still in draft version and purpose of this PR is to get some feedback on the approach for resolving the issue.
Once approach is finalized I will put this PR out of draft version and refactor with adding some tests.
The PR implements logic of fetching blocks from multiple chunks of snapshot file.

Related Issues

Resolves #9676

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working Search:Searchable Snapshots labels Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Compatibility status:

Checks if related components are compatible with change f5ecacb

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

github-actions bot commented Feb 9, 2024

❌ Gradle check result for 1b82213: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Rishikesh1159 <[email protected]>
@Rishikesh1159
Copy link
Member Author

❌ Gradle check result for 04b75fd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#10755

#12336

Copy link
Contributor

✅ Gradle check result for 04b75fd: SUCCESS

Copy link
Contributor

❌ Gradle check result for 40f47e5: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 40f47e5: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimarySingleReplica

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Rishikesh1159 <[email protected]>
Copy link
Contributor

❌ Gradle check result for f1a27f8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for f5ecacb: SUCCESS

@andrross andrross added the backport 2.x Backport to 2.x branch label Feb 27, 2024
@Rishikesh1159 Rishikesh1159 merged commit 3125b94 into opensearch-project:main Feb 27, 2024
33 of 34 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12277-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3125b948029609f354d3153f8ca6391638daefc7
# Push it to GitHub
git push --set-upstream origin backport/backport-12277-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12277-to-2.x.

@andrross
Copy link
Member

@Rishikesh1159 Looks like a backport was missed, causing the conflict on this PR's backport. Can you create the manual backport after #12485 is merged?

@kotwanikunal kotwanikunal added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels Feb 27, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 27, 2024
…pository chunk_size (#12277)

* implement logic of fetching blocks from multiple chunks of snapshot file.

Signed-off-by: Rishikesh1159 <[email protected]>

* Refactor and address comments.

Signed-off-by: Rishikesh1159 <[email protected]>

* apply spotless check

Signed-off-by: Rishikesh1159 <[email protected]>

* Address comments of using a different data structure to fetch blob parts.

Signed-off-by: Rishikesh1159 <[email protected]>

* remove unnecessary code.

Signed-off-by: Rishikesh1159 <[email protected]>

* Refactor outputstream usage.

Signed-off-by: Rishikesh1159 <[email protected]>

* refactor blobpart logic into a separate method and add unit tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* Add new unit tests.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
(cherry picked from commit 3125b94)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kotwanikunal
Copy link
Member

@Rishikesh1159 Looks like a backport was missed, causing the conflict on this PR's backport. Can you create the manual backport after #12485 is merged?

@Rishikesh1159 / @andrross opensearch-bot took care of it :)

kotwanikunal pushed a commit that referenced this pull request Feb 28, 2024
…pository chunk_size (#12277) (#12486)

* implement logic of fetching blocks from multiple chunks of snapshot file.



* Refactor and address comments.



* apply spotless check



* Address comments of using a different data structure to fetch blob parts.



* remove unnecessary code.



* Refactor outputstream usage.



* refactor blobpart logic into a separate method and add unit tests.



* Add new unit tests.



---------


(cherry picked from commit 3125b94)

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
…pository chunk_size (opensearch-project#12277)

* implement logic of fetching blocks from multiple chunks of snapshot file.

Signed-off-by: Rishikesh1159 <[email protected]>

* Refactor and address comments.

Signed-off-by: Rishikesh1159 <[email protected]>

* apply spotless check

Signed-off-by: Rishikesh1159 <[email protected]>

* Address comments of using a different data structure to fetch blob parts.

Signed-off-by: Rishikesh1159 <[email protected]>

* remove unnecessary code.

Signed-off-by: Rishikesh1159 <[email protected]>

* Refactor outputstream usage.

Signed-off-by: Rishikesh1159 <[email protected]>

* refactor blobpart logic into a separate method and add unit tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* Add new unit tests.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 12, 2024
…pository chunk_size (opensearch-project#12277)

* implement logic of fetching blocks from multiple chunks of snapshot file.

Signed-off-by: Rishikesh1159 <[email protected]>

* Refactor and address comments.

Signed-off-by: Rishikesh1159 <[email protected]>

* apply spotless check

Signed-off-by: Rishikesh1159 <[email protected]>

* Address comments of using a different data structure to fetch blob parts.

Signed-off-by: Rishikesh1159 <[email protected]>

* remove unnecessary code.

Signed-off-by: Rishikesh1159 <[email protected]>

* Refactor outputstream usage.

Signed-off-by: Rishikesh1159 <[email protected]>

* refactor blobpart logic into a separate method and add unit tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* Add new unit tests.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Aman Khare <[email protected]>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…pository chunk_size (opensearch-project#12277)

* implement logic of fetching blocks from multiple chunks of snapshot file.

Signed-off-by: Rishikesh1159 <[email protected]>

* Refactor and address comments.

Signed-off-by: Rishikesh1159 <[email protected]>

* apply spotless check

Signed-off-by: Rishikesh1159 <[email protected]>

* Address comments of using a different data structure to fetch blob parts.

Signed-off-by: Rishikesh1159 <[email protected]>

* remove unnecessary code.

Signed-off-by: Rishikesh1159 <[email protected]>

* Refactor outputstream usage.

Signed-off-by: Rishikesh1159 <[email protected]>

* refactor blobpart logic into a separate method and add unit tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* Add new unit tests.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…pository chunk_size (opensearch-project#12277)

* implement logic of fetching blocks from multiple chunks of snapshot file.

Signed-off-by: Rishikesh1159 <[email protected]>

* Refactor and address comments.

Signed-off-by: Rishikesh1159 <[email protected]>

* apply spotless check

Signed-off-by: Rishikesh1159 <[email protected]>

* Address comments of using a different data structure to fetch blob parts.

Signed-off-by: Rishikesh1159 <[email protected]>

* remove unnecessary code.

Signed-off-by: Rishikesh1159 <[email protected]>

* Refactor outputstream usage.

Signed-off-by: Rishikesh1159 <[email protected]>

* refactor blobpart logic into a separate method and add unit tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* Add new unit tests.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Searchable snapshot dependency on repository chunk_size
3 participants