Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test FieldSortIT.testIssue6614 #12259

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

Poojita-Raj
Copy link
Contributor

@Poojita-Raj Poojita-Raj commented Feb 8, 2024

Description

testIssue6614 was a flaky test failing intermittently due to FileSystemException "Too many open files". This was caused due to the high number of shards created by the test (~750 shards).

Reducing the range of possible number of indices created solved this issue with minimal change required to underlying OpenSearchIntegTestCase and the rest of the randomized parameters for the test (shards, replicas, data nodes, etc). It also doesn't affect the logic of the test.

More details in linked issue.

Related Issues

Resolves #11347

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Poojita Raj <[email protected]>
@github-actions github-actions bot added bug Something isn't working flaky-test Random test failure that succeeds on second run labels Feb 8, 2024
@Poojita-Raj Poojita-Raj removed bug Something isn't working flaky-test Random test failure that succeeds on second run labels Feb 8, 2024
@github-actions github-actions bot added bug Something isn't working flaky-test Random test failure that succeeds on second run labels Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Compatibility status:

Checks if related components are compatible with change e22fcb5

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Feb 8, 2024

✅ Gradle check result for e22fcb5: SUCCESS

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (445bf1f) 71.36% compared to head (e22fcb5) 71.31%.
Report is 7 commits behind head on main.

Files Patch % Lines
...opensearch/ingest/common/CommunityIdProcessor.java 85.95% 15 Missing and 18 partials ⚠️
...h/aggregations/bucket/FastFilterRewriteHelper.java 81.66% 9 Missing and 13 partials ⚠️
...egations/bucket/composite/CompositeAggregator.java 90.47% 1 Missing and 1 partial ⚠️
...search/ingest/common/IngestCommonModulePlugin.java 0.00% 1 Missing ⚠️
...ions/bucket/histogram/DateHistogramAggregator.java 87.50% 0 Missing and 1 partial ⚠️
.../org/opensearch/telemetry/tracing/SpanBuilder.java 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12259      +/-   ##
============================================
- Coverage     71.36%   71.31%   -0.06%     
- Complexity    59643    59724      +81     
============================================
  Files          4954     4955       +1     
  Lines        280695   281022     +327     
  Branches      40780    40841      +61     
============================================
+ Hits         200319   200405      +86     
- Misses        63688    63924     +236     
- Partials      16688    16693       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rishikesh1159 Rishikesh1159 added the backport 2.x Backport to 2.x branch label Feb 8, 2024
@Rishikesh1159 Rishikesh1159 merged commit 7b99274 into opensearch-project:main Feb 9, 2024
66 of 123 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 9, 2024
Signed-off-by: Poojita Raj <[email protected]>
(cherry picked from commit 7b99274)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Rishikesh1159 pushed a commit that referenced this pull request Feb 9, 2024
(cherry picked from commit 7b99274)

Signed-off-by: Poojita Raj <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Poojita Raj <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.search.sort.FieldSortIT.testIssue6614 is flaky
6 participants