-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test FieldSortIT.testIssue6614 #12259
Fix flaky test FieldSortIT.testIssue6614 #12259
Conversation
Signed-off-by: Poojita Raj <[email protected]>
Compatibility status:Checks if related components are compatible with change e22fcb5 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git] |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #12259 +/- ##
============================================
- Coverage 71.36% 71.31% -0.06%
- Complexity 59643 59724 +81
============================================
Files 4954 4955 +1
Lines 280695 281022 +327
Branches 40780 40841 +61
============================================
+ Hits 200319 200405 +86
- Misses 63688 63924 +236
- Partials 16688 16693 +5 ☔ View full report in Codecov by Sentry. |
server/src/internalClusterTest/java/org/opensearch/search/sort/FieldSortIT.java
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/search/sort/FieldSortIT.java
Show resolved
Hide resolved
7b99274
into
opensearch-project:main
Signed-off-by: Poojita Raj <[email protected]> (cherry picked from commit 7b99274) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 7b99274) Signed-off-by: Poojita Raj <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Poojita Raj <[email protected]>
Signed-off-by: Poojita Raj <[email protected]>
Signed-off-by: Poojita Raj <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
testIssue6614 was a flaky test failing intermittently due to FileSystemException "Too many open files". This was caused due to the high number of shards created by the test (~750 shards).
Reducing the range of possible number of indices created solved this issue with minimal change required to underlying OpenSearchIntegTestCase and the rest of the randomized parameters for the test (shards, replicas, data nodes, etc). It also doesn't affect the logic of the test.
More details in linked issue.
Related Issues
Resolves #11347
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.