Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable seg-rep for fuzzy filter postings upgrade IT #12183

Merged

Conversation

mgodwan
Copy link
Member

@mgodwan mgodwan commented Feb 6, 2024

Description

Test is flaky as seg-rep is causing issues during lucene codec upgrade. There is a separate test for seg-rep and upgrade. Disabling seg-rep in the fuzzy filter tests

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Compatibility status:

Checks if related components are compatible with change 10d3c7a

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

github-actions bot commented Feb 6, 2024

❌ Gradle check result for 1c01407: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shwetathareja
Copy link
Member

@mgodwan with your change also, the integ test is failing.

@mgodwan mgodwan force-pushed the fuzzyfilter-upgrade-test-fix branch from 1c01407 to b6f99c8 Compare February 6, 2024 09:58
@mgodwan
Copy link
Member Author

mgodwan commented Feb 6, 2024

@mgodwan with your change also, the integ test is failing.

Yes, I hadn't removed the assertion which verified all nodes have same segments in seg-rep mode. Verifying the doc count now only similar to other indexing tests with doc-rep mode.
Tests passed locally over 50 times.
Will monitor the ongoing checks on the PR

@shwetathareja shwetathareja self-requested a review February 6, 2024 10:29
Copy link
Contributor

github-actions bot commented Feb 6, 2024

❌ Gradle check result for b6f99c8: ABORTED

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan mgodwan force-pushed the fuzzyfilter-upgrade-test-fix branch from b6f99c8 to 10d3c7a Compare February 6, 2024 12:06
Copy link
Contributor

github-actions bot commented Feb 6, 2024

❌ Gradle check result for 10d3c7a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan
Copy link
Member Author

mgodwan commented Feb 6, 2024

Failing test:

Tests with failures:
 - org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

This is marked flaky here: #9191

@mgodwan
Copy link
Member Author

mgodwan commented Feb 6, 2024

@shwetathareja shwetathareja merged commit cf3bbb8 into opensearch-project:main Feb 6, 2024
27 of 28 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2024
Signed-off-by: mgodwan <[email protected]>
(cherry picked from commit cf3bbb8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mch2
Copy link
Member

mch2 commented Feb 6, 2024

@mgodwan am not opposed to this change but would like to understand more on the failure and where this differs with the segrep specific test. Do you have a link to a failed check due to codec upgrade with segrep? I would expect the segrep test to have similar flakiness then as the test is not currently setting the shard movement strategy to ensure primary shards move last.

@mgodwan
Copy link
Member Author

mgodwan commented Feb 6, 2024

@mch2 you can use this gradle check run to see the failure: https://build.ci.opensearch.org/job/gradle-check/33349/console

Essentially, the failure was due to primary shard writing segments with Lucene99Codec and replica on the older OS version node being unable to read the same

»  Caused by: java.lang.IllegalArgumentException: An SPI class of type org.apache.lucene.codecs.Codec with name 'Lucene99' does not exist.  You need to add the corresponding JAR file supporting this SPI to your classpath.  The current classpath supports the following names: [Lucene95, Lucene80, Lucene84, Lucene86, Lucene87, Lucene70, Lucene90, Lucene91, Lucene92, Lucene94]

shwetathareja pushed a commit that referenced this pull request Feb 6, 2024
(cherry picked from commit cf3bbb8)

Signed-off-by: mgodwan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants