-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable seg-rep for fuzzy filter postings upgrade IT #12183
Disable seg-rep for fuzzy filter postings upgrade IT #12183
Conversation
Compatibility status:Checks if related components are compatible with change 10d3c7a Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for 1c01407: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@mgodwan with your change also, the integ test is failing. |
1c01407
to
b6f99c8
Compare
Yes, I hadn't removed the assertion which verified all nodes have same segments in seg-rep mode. Verifying the doc count now only similar to other indexing tests with doc-rep mode. |
❌ Gradle check result for b6f99c8: ABORTED Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: mgodwan <[email protected]>
b6f99c8
to
10d3c7a
Compare
❌ Gradle check result for 10d3c7a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Failing test:
This is marked flaky here: #9191 |
Test modified in this PR has passed: https://build.ci.opensearch.org/job/gradle-check/33366/testReport/org.opensearch.upgrades/IndexingIT/ |
Signed-off-by: mgodwan <[email protected]> (cherry picked from commit cf3bbb8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mgodwan am not opposed to this change but would like to understand more on the failure and where this differs with the segrep specific test. Do you have a link to a failed check due to codec upgrade with segrep? I would expect the segrep test to have similar flakiness then as the test is not currently setting the shard movement strategy to ensure primary shards move last. |
@mch2 you can use this gradle check run to see the failure: https://build.ci.opensearch.org/job/gradle-check/33349/console Essentially, the failure was due to primary shard writing segments with Lucene99Codec and replica on the older OS version node being unable to read the same
|
(cherry picked from commit cf3bbb8) Signed-off-by: mgodwan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ect#12183) Signed-off-by: mgodwan <[email protected]>
…ect#12183) Signed-off-by: mgodwan <[email protected]>
…ect#12183) Signed-off-by: mgodwan <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Test is flaky as seg-rep is causing issues during lucene codec upgrade. There is a separate test for seg-rep and upgrade. Disabling seg-rep in the fuzzy filter tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.