Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Cleanup file cache on deleting index/shard directory #12154

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c564ee3 from #11443.

* cleanup file cache on deleting index/shard directory

Signed-off-by: panguixin <[email protected]>

* add index store listener

Signed-off-by: panguixin <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
(cherry picked from commit c564ee3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Feb 3, 2024

Compatibility status:

Checks if related components are compatible with change 36493ab

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git]

Copy link
Contributor

github-actions bot commented Feb 3, 2024

❌ Gradle check result for 36493ab: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 7, 2024

✅ Gradle check result for 36493ab: SUCCESS

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (4faa3eb) 71.05% compared to head (36493ab) 71.11%.
Report is 29 commits behind head on 2.x.

Files Patch % Lines
...index/store/remote/filecache/FileCacheCleaner.java 60.86% 5 Missing and 4 partials ⚠️
.../main/java/org/opensearch/env/NodeEnvironment.java 57.89% 8 Missing ⚠️
.../opensearch/rest/action/cat/RestIndicesAction.java 50.00% 0 Missing and 8 partials ⚠️
...rg/opensearch/rest/action/cat/RestNodesAction.java 50.00% 0 Missing and 4 partials ⚠️
.../main/java/org/opensearch/search/SearchModule.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12154      +/-   ##
============================================
+ Coverage     71.05%   71.11%   +0.06%     
- Complexity    59441    59501      +60     
============================================
  Files          4894     4894              
  Lines        280304   280303       -1     
  Branches      41115    41108       -7     
============================================
+ Hits         199161   199329     +168     
+ Misses        64284    64126     -158     
+ Partials      16859    16848      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit 11bea3d into 2.x Feb 20, 2024
56 of 83 checks passed
@github-actions github-actions bot deleted the backport/backport-11443-to-2.x branch February 20, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants