Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Remove Concurrent Segment Search feature flags for feature launch (#12074) #12152

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented Feb 2, 2024

Description

Manual backport for #12074

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jed326
Copy link
Collaborator Author

jed326 commented Feb 2, 2024

@reta @andrross here's the backport 2.x for #12074. Updated the bwc versions to 2.12 for the yaml rest-api-spec tests here too.

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Compatibility status:

Checks if related components are compatible with change 0a05505

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

github-actions bot commented Feb 2, 2024

❕ Gradle check result for 0a05505: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction
      2 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (4faa3eb) 71.05% compared to head (0a05505) 71.08%.

Files Patch % Lines
.../opensearch/rest/action/cat/RestIndicesAction.java 50.00% 0 Missing and 8 partials ⚠️
...rg/opensearch/rest/action/cat/RestNodesAction.java 50.00% 0 Missing and 4 partials ⚠️
.../main/java/org/opensearch/search/SearchModule.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12152      +/-   ##
============================================
+ Coverage     71.05%   71.08%   +0.03%     
- Complexity    59441    59469      +28     
============================================
  Files          4894     4894              
  Lines        280304   280284      -20     
  Branches      41115    41105      -10     
============================================
+ Hits         199161   199238      +77     
+ Misses        64284    64147     -137     
- Partials      16859    16899      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit a70ddcc into opensearch-project:2.x Feb 3, 2024
83 of 84 checks passed
@@ -1,7 +1,7 @@
"Help":
- skip:
version: " - 2.11.99"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jed326 could you please bring these test version changes to main as well? Thank you

@jed326 jed326 deleted the backport-12074 branch March 12, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants