Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Support for Google Application Default Credentials (#8394) #12080

Merged

Conversation

yallen-ic
Copy link

backport #8394 to 2.x

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Compatibility status:

Checks if related components are compatible with change 475f7dc

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git]

Copy link
Contributor

❌ Gradle check result for 9b1b7ea: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross andrross force-pushed the backport/backport-8394-to-2.x branch from 9b1b7ea to b43ebfa Compare January 30, 2024 16:44
…t#8394)

* fixed conflicts

Signed-off-by: fahadshamiinsta <[email protected]>

* applying spotless Java check

Signed-off-by: fahadshamiinsta <[email protected]>

* added a comment to test helper  method

Signed-off-by: fahadshamiinsta <[email protected]>

* added a comment to GoogleApplicationDefaultCredentials class with document reference

Signed-off-by: fahadshamiinsta <[email protected]>

* to rerun gradle checks

Signed-off-by: fahadshamiinsta <[email protected]>

* increasing coverage by adding another test

Signed-off-by: fahadshamiinsta <[email protected]>

* test name change

Signed-off-by: fahadshamiinsta <[email protected]>

* rerun ci

Signed-off-by: fahadshamiinsta <[email protected]>

* rerun ci

Signed-off-by: fahadshamiinsta <[email protected]>

* force push to rerun ci

Signed-off-by: fahadshamiinsta <[email protected]>

* pushing to trigger ci checks

Signed-off-by: fahadshamiinsta <[email protected]>

---------

Signed-off-by: fahadshamiinsta <[email protected]>
(cherry picked from commit 4c283a7)
@andrross andrross force-pushed the backport/backport-8394-to-2.x branch from b43ebfa to 475f7dc Compare January 30, 2024 16:50
@andrross
Copy link
Member

andrross commented Jan 30, 2024

I rebased and cherry-picked this commit again from main and fixed up the CHANGELOG. The DCO check is still failing, which is odd since the commit is directly cherry-picked from main. The author did sign the commit, but the signed email address doesn't match what is in the git commit metadata.

@andrross andrross added the v2.12.0 Issues and PRs related to version 2.12.0 label Jan 30, 2024
Copy link
Contributor

❕ Gradle check result for b43ebfa: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
      1 org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (08bbddc) 71.05% compared to head (475f7dc) 71.15%.
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...ories/gcs/GoogleApplicationDefaultCredentials.java 75.00% 2 Missing ⚠️
...in/java/org/opensearch/index/shard/IndexShard.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12080      +/-   ##
============================================
+ Coverage     71.05%   71.15%   +0.10%     
- Complexity    59360    59396      +36     
============================================
  Files          4891     4892       +1     
  Lines        279982   280005      +23     
  Branches      41070    41073       +3     
============================================
+ Hits         198937   199237     +300     
+ Misses        64239    63841     -398     
- Partials      16806    16927     +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❕ Gradle check result for 475f7dc: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@kotwanikunal kotwanikunal merged commit 8cfa96f into opensearch-project:2.x Jan 31, 2024
32 of 34 checks passed
@yallen-ic yallen-ic deleted the backport/backport-8394-to-2.x branch January 31, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants