-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test SegmentReplicationStatsIT.testMultipleIndices #12070
Fix flaky test SegmentReplicationStatsIT.testMultipleIndices #12070
Conversation
❌ Gradle check result for 636a546: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change 7f020c4 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git] |
No discernable failures. |
❌ Gradle check result for 636a546: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
FAILURE: Build failed with an exception.
|
@Poojita-Raj can you please rebase your branch with latest changes in main. |
Signed-off-by: Poojita Raj <[email protected]>
636a546
to
7f020c4
Compare
❌ Gradle check result for 7f020c4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Could you please update your PR so only the lines that changed show up in the diff? |
❌ Gradle check result for 7f020c4: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 7f020c4: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12070 +/- ##
============================================
+ Coverage 71.31% 71.42% +0.11%
- Complexity 59423 59509 +86
============================================
Files 4925 4925
Lines 279513 279520 +7
Branches 40643 40645 +2
============================================
+ Hits 199329 199661 +332
+ Misses 63594 63221 -373
- Partials 16590 16638 +48 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Poojita Raj <[email protected]> (cherry picked from commit 2f8d267) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#12100) (cherry picked from commit 2f8d267) Signed-off-by: Poojita Raj <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…rch-project#12070) Signed-off-by: Poojita Raj <[email protected]>
…rch-project#12070) Signed-off-by: Poojita Raj <[email protected]>
…rch-project#12070) Signed-off-by: Poojita Raj <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Fixes flaky test SegmentReplicationStatsIT.testMultipleIndices. The test was failing an assertion error on the replica stats after the segmentReplicationStatsResponse was received. We fix this by adding in an assertBusy on the stats request call.
Ran the test 1000 times and an additional 200 times as part of the SegmentReplicationStatsIT test suite.
Related Issues
Resolves #11454
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.