Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metric Framework] Adds support for Histogram metric #12062

Merged
merged 11 commits into from
Feb 5, 2024

Addresses review comments

a0b5034
Select commit
Loading
Failed to load commit list.
Merged

[Metric Framework] Adds support for Histogram metric #12062

Addresses review comments
a0b5034
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 5, 2024 in 1s

71.39% (target 70.00%)

View this Pull Request on Codecov

71.39% (target 70.00%)

Details

Codecov Report

Attention: 135 lines in your changes are missing coverage. Please review.

Comparison is base (a8dd6a0) 71.26% compared to head (a0b5034) 71.39%.
Report is 7 commits behind head on main.

Files Patch % Lines
...search/repositories/fs/ReloadableFsRepository.java 31.03% 40 Missing ⚠️
...h/index/codec/fuzzy/FuzzyFilterPostingsFormat.java 85.44% 18 Missing and 5 partials ⚠️
...java/org/opensearch/index/shard/StoreRecovery.java 0.00% 18 Missing and 2 partials ⚠️
.../main/java/org/opensearch/index/IndexSettings.java 50.00% 10 Missing ⚠️
...in/java/org/opensearch/index/shard/IndexShard.java 38.46% 7 Missing and 1 partial ⚠️
...ndex/codec/fuzzy/IndexInputImmutableLongArray.java 46.15% 7 Missing ⚠️
.../org/opensearch/index/codec/fuzzy/BloomFilter.java 90.74% 2 Missing and 3 partials ⚠️
...ava/org/opensearch/index/codec/fuzzy/FuzzySet.java 70.58% 2 Missing and 3 partials ⚠️
.../opensearch/index/codec/fuzzy/FuzzySetFactory.java 63.63% 2 Missing and 2 partials ⚠️
...ensearch/telemetry/metrics/noop/NoopHistogram.java 0.00% 3 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12062      +/-   ##
============================================
+ Coverage     71.26%   71.39%   +0.12%     
- Complexity    59413    59572     +159     
============================================
  Files          4927     4937      +10     
  Lines        279662   280110     +448     
  Branches      40656    40703      +47     
============================================
+ Hits         199311   199984     +673     
+ Misses        63725    63530     -195     
+ Partials      16626    16596      -30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov