Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Searchable Snapshot] Add Relevant Error handling for Restore API with remote_snapshot. #12011

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7da8628 from #11840.

…h remote_snapshot. (#11840)

* Add Relevant Error handling for Restore API with remote_snapshot.

Signed-off-by: Rishikesh1159 <[email protected]>

* update comment with more revelant info.

Signed-off-by: Rishikesh1159 <[email protected]>

* apply spotless check.

Signed-off-by: Rishikesh1159 <[email protected]>

* Add null check

Signed-off-by: Rishikesh1159 <[email protected]>

* apply spotless check.

Signed-off-by: Rishikesh1159 <[email protected]>

* fix error message in test.

Signed-off-by: Rishikesh1159 <[email protected]>

* apply spotless check.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Rishikesh Pasham <[email protected]>
(cherry picked from commit 7da8628)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 7b21f3c

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git]

Copy link
Contributor

❌ Gradle check result for 7b21f3c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross
Copy link
Member

❌ Gradle check result for 7b21f3c: FAILURE

#11875
#8947

Copy link
Contributor

❕ Gradle check result for 7b21f3c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.snapshots.CloneSnapshotIT.testCloneAfterRepoShallowSettingEnabled
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit
      1 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermarkWithAutoReleaseEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b72f1d1) 71.12% compared to head (7b21f3c) 71.04%.
Report is 2 commits behind head on 2.x.

Files Patch % Lines
.../java/org/opensearch/snapshots/RestoreService.java 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12011      +/-   ##
============================================
- Coverage     71.12%   71.04%   -0.08%     
+ Complexity    59384    59336      -48     
============================================
  Files          4891     4891              
  Lines        279944   279949       +5     
  Branches      41055    41056       +1     
============================================
- Hits         199113   198901     -212     
- Misses        63904    64153     +249     
+ Partials      16927    16895      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kotwanikunal kotwanikunal merged commit 38c4b39 into 2.x Jan 24, 2024
56 of 83 checks passed
@github-actions github-actions bot deleted the backport/backport-11840-to-2.x branch January 24, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants