Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstracting Writeable to support multiple protocols #11958

Closed
wants to merge 1 commit into from

Conversation

VachaShah
Copy link
Collaborator

@VachaShah VachaShah commented Jan 20, 2024

Description

Coming from #11910 (comment), abstracting out Writeable so that other serialization/deserialization protocols can be added extending BaseWriteable.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
Part of #10684

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 8537e4e

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security.git]

Copy link
Contributor

✅ Gradle check result for 8537e4e: SUCCESS

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e265355) 71.41% compared to head (8537e4e) 71.33%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11958      +/-   ##
============================================
- Coverage     71.41%   71.33%   -0.09%     
+ Complexity    59397    59380      -17     
============================================
  Files          4923     4923              
  Lines        279212   279212              
  Branches      40595    40595              
============================================
- Hits         199408   199184     -224     
- Misses        63223    63473     +250     
+ Partials      16581    16555      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VachaShah
Copy link
Collaborator Author

Incorporating the abstractions in #11910 itself. Closing this PR.

@VachaShah VachaShah closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant