Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Apply the fast filter optimization to composite aggregation (#11505) #11911

Closed

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Jan 17, 2024

We can do efficient DateHistogram aggregation under composite aggregations.


Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ch-project#11505)

We can do efficient DateHistogram aggregation under composite 
aggregations.

---------

Signed-off-by: bowenlan-amzn <[email protected]>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change cc815d3

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

✅ Gradle check result for cc815d3: SUCCESS

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (923aa25) 71.16% compared to head (cc815d3) 71.23%.
Report is 43 commits behind head on 2.x.

Files Patch % Lines
...h/aggregations/bucket/FastFilterRewriteHelper.java 88.88% 3 Missing and 12 partials ⚠️
...egations/bucket/composite/CompositeAggregator.java 88.37% 3 Missing and 2 partials ⚠️
...gregations/bucket/composite/InternalComposite.java 0.00% 2 Missing ⚠️
...ions/bucket/histogram/DateHistogramAggregator.java 84.61% 0 Missing and 2 partials ⚠️
...org/opensearch/gradle/RepositoriesSetupPlugin.java 0.00% 1 Missing ⚠️
.../bucket/histogram/AutoDateHistogramAggregator.java 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11911      +/-   ##
============================================
+ Coverage     71.16%   71.23%   +0.06%     
- Complexity    59350    59412      +62     
============================================
  Files          4885     4885              
  Lines        279506   279589      +83     
  Branches      40967    40989      +22     
============================================
+ Hits         198919   199173     +254     
+ Misses        63766    63558     -208     
- Partials      16821    16858      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowenlan-amzn bowenlan-amzn deleted the backport11505 branch January 18, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant