Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Remove unused segment replication feature flag #11852

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport de78c7c from #11850.

This feature has been released and the feature flag is no longer used.

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit de78c7c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 55d9b17

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/k-nn.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❕ Gradle check result for 55d9b17: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (a41646e) 71.16% compared to head (55d9b17) 71.12%.
Report is 3 commits behind head on 2.x.

Files Patch % Lines
...ch/common/xcontent/JsonToStringXContentParser.java 81.25% 1 Missing and 2 partials ⚠️
.../java/org/opensearch/index/codec/CodecService.java 66.66% 2 Missing ⚠️
...org/opensearch/index/fielddata/IndexFieldData.java 33.33% 1 Missing and 1 partial ⚠️
...eldcomparator/HalfFloatValuesComparatorSource.java 0.00% 1 Missing ⚠️
...comparator/UnsignedLongValuesComparatorSource.java 0.00% 1 Missing ⚠️
...opensearch/index/mapper/CompletionFieldMapper.java 0.00% 1 Missing ⚠️
.../index/search/comparators/HalfFloatComparator.java 0.00% 1 Missing ⚠️
...dex/search/comparators/UnsignedLongComparator.java 0.00% 1 Missing ⚠️
...opensearch/search/sort/GeoDistanceSortBuilder.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11852      +/-   ##
============================================
- Coverage     71.16%   71.12%   -0.05%     
- Complexity    59378    59394      +16     
============================================
  Files          4889     4889              
  Lines        279821   279805      -16     
  Branches      41034    41032       -2     
============================================
- Hits         199141   199014     -127     
- Misses        63778    63958     +180     
+ Partials      16902    16833      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kotwanikunal kotwanikunal merged commit c440508 into 2.x Jan 11, 2024
57 of 83 checks passed
@github-actions github-actions bot deleted the backport/backport-11850-to-2.x branch January 11, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants