Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmute testNoFailuresOnFileReads flaky test #11824

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Jan 9, 2024

Description

The test fails while asserting non-emtpy set of corrupted files here. I suspect the failure happens because first round of segment replication completes pre-maturely without actually copying any files, which breaks this assertion. This is possible as listener (for copying files) gets resolved immediately due to exception inside custom RemoteStoreReplicationSource. The actual file copy continues async BUT inside test we have already proceeded on validating assertions, which breaks. I recently fixed the logic to appropriately wait for files to copy over before performing any follow up action (corruption in this case). So as part of this change, we only need to unmute this test.

Error stack trace

java.lang.AssertionError
	at __randomizedtesting.SeedInfo.seed([A71542B40F44C18D:825D5DA2CC1735C3]:0)
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertNotNull(Assert.java:713)
	at org.junit.Assert.assertNotNull(Assert.java:723)
	at org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads(RemoteIndexShardTests.java:512)
...

Issues

Resolves #10945

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
    - [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Compatibility status:

Checks if related components are compatible with change aeb8a6c

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Jan 9, 2024

❕ Gradle check result for aeb8a6c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71f1fab) 71.34% compared to head (aeb8a6c) 71.28%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11824      +/-   ##
============================================
- Coverage     71.34%   71.28%   -0.07%     
- Complexity    59195    59220      +25     
============================================
  Files          4913     4913              
  Lines        278741   278745       +4     
  Branches      40529    40529              
============================================
- Hits         198872   198694     -178     
- Misses        63317    63509     +192     
+ Partials      16552    16542      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dreamer-89 dreamer-89 added the backport 2.x Backport to 2.x branch label Jan 9, 2024
@dreamer-89
Copy link
Member Author

❕ Gradle check result for aeb8a6c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

#9191

@dreamer-89 dreamer-89 merged commit a9ce180 into opensearch-project:main Jan 9, 2024
101 of 173 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 9, 2024
Signed-off-by: Suraj Singh <[email protected]>
(cherry picked from commit a9ce180)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89 pushed a commit that referenced this pull request Jan 9, 2024
(cherry picked from commit a9ce180)

Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run skip-changelog Storage:Remote
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads
4 participants