-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmute testNoFailuresOnFileReads flaky test #11824
Conversation
Signed-off-by: Suraj Singh <[email protected]>
Compatibility status:Checks if related components are compatible with change aeb8a6c Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git] |
❕ Gradle check result for aeb8a6c: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11824 +/- ##
============================================
- Coverage 71.34% 71.28% -0.07%
- Complexity 59195 59220 +25
============================================
Files 4913 4913
Lines 278741 278745 +4
Branches 40529 40529
============================================
- Hits 198872 198694 -178
- Misses 63317 63509 +192
+ Partials 16552 16542 -10 ☔ View full report in Codecov by Sentry. |
|
Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit a9ce180) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit a9ce180) Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
The test fails while asserting non-emtpy set of corrupted files here. I suspect the failure happens because first round of segment replication completes pre-maturely without actually copying any files, which breaks this assertion. This is possible as listener (for copying files) gets resolved immediately due to exception inside custom RemoteStoreReplicationSource. The actual file copy continues async BUT inside test we have already proceeded on validating assertions, which breaks. I recently fixed the logic to appropriately wait for files to copy over before performing any follow up action (corruption in this case). So as part of this change, we only need to unmute this test.
Error stack trace
Issues
Resolves #10945
Check List
- [ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.