Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segment Replication] Introduce cluster level setting cluster.indexrestrict.replication.type to prevent replication type setting override during index creations (#11583) #11707

Merged
merged 2 commits into from
Jan 2, 2024
Merged

[Segment Replication] Introduce cluster level setting cluster.indexrestrict.replication.type to prevent replication type setting override during index creations (#11583) #11707

merged 2 commits into from
Jan 2, 2024

Conversation

dreamer-89
Copy link
Member

Manual backport of #11583 to 2.x branch.

@dreamer-89
[Segment Replication] Introduce cluster level setting `cluster.index.…
40e48c0 
…restrict.replication.type` to prevent replication type setting override during index creations (opensearch-project#11583)

* Add new cluster level setting that prevents index level replication type setting overrides

Signed-off-by: Suraj Singh <[email protected]>

* Block restore on mis-matching replication type setting

Signed-off-by: Suraj Singh <[email protected]>

* Address review comments and rebase

Signed-off-by: Suraj Singh <[email protected]>

* Address review comments

Signed-off-by: Suraj Singh <[email protected]>

* Use appropriate variable names

Signed-off-by: Suraj Singh <[email protected]>

* Fix failing integ test

Signed-off-by: Suraj Singh <[email protected]>

---------

Signed-off-by: Suraj Singh <[email protected]>
(cherry picked from commit 6a6ab32)
@dreamer-89
Remove duplicate IndicesService.CLUSTER_REMOTE_INDEX_RESTRICT_ASYNC_D…
d59c798 
…URABILITY_SETTING setting introduce from conflict resolution

Signed-off-by: Suraj Singh <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change d59c798

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

❌ Gradle check result for 40e48c0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

❌ Gradle check result for d59c798: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dreamer-89
Copy link
Member Author

❌ Gradle check result for 40e48c0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test #10006

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

✅ Gradle check result for d59c798: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ab9c3c6) 71.15% compared to head (d59c798) 71.14%.
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...h/cluster/metadata/MetadataCreateIndexService.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #11707      +/-   ##
============================================
- Coverage     71.15%   71.14%   -0.02%     
+ Complexity    59365    59358       -7     
============================================
  Files          4883     4883              
  Lines        279314   279328      +14     
  Branches      40934    40935       +1     
============================================
- Hits         198749   198723      -26     
- Misses        63740    63815      +75     
+ Partials      16825    16790      -35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kotwanikunal kotwanikunal merged commit 37f788f into opensearch-project:2.x Jan 2, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@setiah setiah Awaiting requested review from setiah

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreamer-89 @kotwanikunal