[Backport 2.x] Add getter for path field in NestedQueryBuilder #11657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) (cherry picked from commit 7b7ca98) Signed-off-by: psmagin <[email protected]>
psmagin
changed the title
Compatibility status:Checks if related components are compatible with change dcfd011 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security.git] |
|
❕ Gradle check result for aa0bdf0: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #11657 +/- ##
============================================
- Coverage 71.23% 71.13% -0.10%
+ Complexity 59487 59370 -117
============================================
Files 4891 4891
Lines 279940 279941 +1
Branches 41055 41055
============================================
- Hits 199404 199128 -276
- Misses 63673 63930 +257
- Partials 16863 16883 +20 ☔ View full report in Codecov by Sentry. |
psmagin
requested review from
abbashus,
adnapibar,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
setiah,
shwetathareja and
sohami
as code owners
kkmr
approved these changes
Dec 25, 2023
|
@dblock, please review this backport. You had requested it some time ago. |
Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
dblock
approved these changes
Jan 10, 2024
|
❌ Gradle check result for 11ebf3b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@psmagin check out the gradle failures? rebase? |
There is something with test that has no relation to my changes. Bug for this test was already created: #9191 |
deshsidd
approved these changes
Jan 11, 2024
|
Looks like a build is now failing. Please take a look @psmagin |
|
Looks like the following test is failing : org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterRestoreGlobalMetadata Most likely a transient failure. Maybe try re-triggerring the build with empty commit. |
Signed-off-by: Pavlo Smahin <[email protected]>
|
❕ Gradle check result for dcfd011: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
Looks like the approval workflow is stuck. @peternied Can you please help here? |
kotwanikunal
approved these changes
Jan 24, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 7b7ca98 from #4636.