-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Automatically add scheme to discovery.ec2.endpoint (#11512) #11603
[Backport 2.x] Automatically add scheme to discovery.ec2.endpoint (#11512) #11603
Conversation
@peternied backport 2.x from #11512 |
Compatibility status:Checks if related components are compatible with change 89cb414 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/security-analytics.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for d697a11: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for d697a11: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@heyanlong Can you please rebase? |
…t#11512) Signed-off-by: Yanlong He <[email protected]> Signed-off-by: 何延龙 <[email protected]> (cherry picked from commit a8da66c)
d697a11
to
89cb414
Compare
Rebase to 68a415c |
❕ Gradle check result for 89cb414: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #11603 +/- ##
============================================
- Coverage 71.22% 71.05% -0.17%
+ Complexity 59378 59249 -129
============================================
Files 4883 4883
Lines 279302 279308 +6
Branches 40933 40934 +1
============================================
- Hits 198937 198476 -461
- Misses 63586 64016 +430
- Partials 16779 16816 +37 ☔ View full report in Codecov by Sentry. |
Description
Fix the problem that
discovery.ec2.endpoint
forgets to fill in the schemehttps://docs.aws.amazon.com/general/latest/gr/rande.html#ec2_region
Example
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.