Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Automatically add scheme to discovery.ec2.endpoint (#11512) #11603

Merged

Conversation

heyanlong
Copy link
Contributor

Description

Fix the problem that discovery.ec2.endpoint forgets to fill in the scheme
https://docs.aws.amazon.com/general/latest/gr/rande.html#ec2_region

Example

discovery.ec2.endpoint: ec2.us-east-1.amazonaws.com

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@heyanlong heyanlong changed the title Automatically add scheme to discovery.ec2.endpoint (#11512) Automatically add scheme to discovery.ec2.endpoint (backport 2.x) (#11512) Dec 13, 2023
@heyanlong heyanlong marked this pull request as ready for review December 13, 2023 02:21
@heyanlong
Copy link
Contributor Author

@peternied backport 2.x from #11512

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Compatibility status:

Checks if related components are compatible with change 89cb414

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for d697a11: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peternied peternied changed the title Automatically add scheme to discovery.ec2.endpoint (backport 2.x) (#11512) [Backport 2.x] Automatically add scheme to discovery.ec2.endpoint (#11512) Dec 13, 2023
Copy link
Contributor

❌ Gradle check result for d697a11: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kotwanikunal
Copy link
Member

@heyanlong Can you please rebase?

…t#11512)

Signed-off-by: Yanlong He <[email protected]>
Signed-off-by: 何延龙 <[email protected]>
(cherry picked from commit a8da66c)
@heyanlong heyanlong force-pushed the backport/backport-11512-to-2.x branch from d697a11 to 89cb414 Compare December 13, 2023 06:11
@heyanlong
Copy link
Contributor Author

@heyanlong Can you please rebase?

Rebase to 68a415c

Copy link
Contributor

❕ Gradle check result for 89cb414: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68a415c) 71.22% compared to head (89cb414) 71.05%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11603      +/-   ##
============================================
- Coverage     71.22%   71.05%   -0.17%     
+ Complexity    59378    59249     -129     
============================================
  Files          4883     4883              
  Lines        279302   279308       +6     
  Branches      40933    40934       +1     
============================================
- Hits         198937   198476     -461     
- Misses        63586    64016     +430     
- Partials      16779    16816      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied merged commit 2cbe873 into opensearch-project:2.x Dec 13, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants