update: remove COMPAT locale provider, change to CLDR

[hurutoriya]

Description

remove COMPAT locale provider, change to CLDR

Related Issues

Resolves #11550

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change 137e887

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git]

[github-actions]

❌ Gradle check result for b262aae: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for f450005: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[hurutoriya]

https://build.ci.opensearch.org/job/gradle-check/31064/testReport/org.opensearch.index.mapper/DateFieldMapperTests/testChangeLocale/

org.opensearch.index.mapper.DateFieldMapperTests.testChangeLocale
MapperParsingException[failed to parse field [field] of type [date] in document with id '1'. Preview of field's value: 'Mi, 06 Dez 2000 02:55:00 -0800']; nested: IllegalArgumentException[failed to parse date field [Mi, 06 Dez 2000 02:55:00 -0800] with format [E, d MMM yyyy HH:mm:ss Z]]; nested: DateTimeParseException[Text 'Mi, 06 Dez 2000 02:55:00 -0800' could not be parsed at index 0];

Hmm, It seems this test error not related to my PR?

Test error point

OpenSearch/server/src/test/java/org/opensearch/index/mapper/DateFieldMapperTests.java

Line 188 in 3c14cc1

public void testChangeLocale() throws IOException {

[dblock]

@hurutoriya iterate to green, if you're hitting flaky tests, see https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests for how to deal with those

[dblock]

Are there any downsides of this change?

[hurutoriya]

@dblock
Thank you for commenting 🙇

Are there any downsides of this change?

Actually, I am a super beginner in OpenSearch and Java. I need to study this downside effect.

[reta]

Actually, I am a super beginner in OpenSearch and Java. I need to study this downside effect.

@dblock @hurutoriya this change, as per https://openjdk.org/jeps/252, has the following impact:

Locale-sensitive services such as date, time, and number formatting may behave differently for locales not supported in JDK 8. Existing tests and applications will need to be modified.

The tests which are failing are consequences of that (at least it looks like such)

[github-actions]

❌ Gradle check result for 137e887: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[andrross]

@hurutoriya Looks like the tests are still failing here. Can you take another look?

[bbarani]

@hurutoriya Can you please look in to the failing tests?

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.