Updating Ip fields to use doc_values to search #11508

harshavamsi · 2023-12-07T01:29:30Z

Description

Fixes term and range queries on IpFields to be able to perform searches when only doc_values is enabled.

Related Issues

Resolves #11144

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-12-07T01:51:45Z

Compatibility status:

Checks if related components are compatible with change 407b723

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

github-actions · 2023-12-07T01:56:37Z

❌ Gradle check result for 4b2b0c5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-12-07T02:05:38Z

❌ Gradle check result for f15a2ae: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

github-actions · 2024-01-29T18:45:54Z

❕ Gradle check result for 407b723: UNSTABLE

TEST FAILURES:

      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

reta · 2024-01-29T19:59:33Z

@andrross LGTY? :-)

* Updating Ip fields to use doc_values to search Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix IP tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix skip to allow yaml test to pass on main Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update tests to use existing test file Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Changing skip version to match bwc Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Using exact match instead of range Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Spotless Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix IP field tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix spotless + precommit failure Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Get point out of query and into value Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix term tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Add skip test logic to only doc_values test Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]> (cherry picked from commit cc9ee9d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Updating Ip fields to use doc_values to search Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix IP tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix skip to allow yaml test to pass on main Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update tests to use existing test file Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Changing skip version to match bwc Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Using exact match instead of range Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Spotless Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix IP field tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix spotless + precommit failure Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Get point out of query and into value Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix term tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Add skip test logic to only doc_values test Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]> (cherry picked from commit cc9ee9d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]>

* Updating Ip fields to use doc_values to search * Fix IP tests * Fix skip to allow yaml test to pass on main * Update tests to use existing test file * Changing skip version to match bwc * Using exact match instead of range * Spotless * Fix IP field tests * Fix spotless + precommit failure * Get point out of query and into value * Fix term tests * Add skip test logic to only doc_values test --------- (cherry picked from commit cc9ee9d) Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

) * Updating Ip fields to use doc_values to search Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix IP tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix skip to allow yaml test to pass on main Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update tests to use existing test file Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Changing skip version to match bwc Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Using exact match instead of range Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Spotless Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix IP field tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix spotless + precommit failure Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Get point out of query and into value Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix term tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Add skip test logic to only doc_values test Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

) * Updating Ip fields to use doc_values to search Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix IP tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix skip to allow yaml test to pass on main Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update tests to use existing test file Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Changing skip version to match bwc Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Using exact match instead of range Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Spotless Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix IP field tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix spotless + precommit failure Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Get point out of query and into value Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix term tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Add skip test logic to only doc_values test Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>

mkhludnev · 2024-11-12T15:07:05Z

I'm afraid there is an edge case cc9ee9d#r148997353

msfroh · 2024-11-12T19:11:01Z

I'm afraid there is an edge case

@mkhludnev -- are you able to fix that as part of #16391 ? If not, we can open a separate issue for it.

mkhludnev · 2024-11-13T09:51:09Z

#16628 here we go. #16391 turns out deeper than I though. tbc

github-actions bot added enhancement Enhancement or improvement to existing feature or request Search:Performance v2.12.0 Issues and PRs related to version 2.12.0 labels Dec 7, 2023

harshavamsi force-pushed the ipfield_iodvq branch from 4b2b0c5 to f15a2ae Compare December 7, 2023 01:30

harshavamsi marked this pull request as ready for review December 7, 2023 23:01

harshavamsi added 9 commits January 29, 2024 09:50

Update tests to use existing test file

4a3aff8

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

Changing skip version to match bwc

8e661c0

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

Using exact match instead of range

3ae54b6

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

Spotless

89876e0

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

Fix IP field tests

3d6f4cc

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

Fix spotless + precommit failure

a84588e

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

Get point out of query and into value

d455bee

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

Fix term tests

468313a

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

Add skip test logic to only doc_values test

407b723

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

harshavamsi force-pushed the ipfield_iodvq branch from ef9b400 to 407b723 Compare January 29, 2024 17:54

msfroh approved these changes Jan 29, 2024

View reviewed changes

andrross approved these changes Jan 30, 2024

View reviewed changes

andrross added the backport 2.x Backport to 2.x branch label Jan 30, 2024

andrross merged commit cc9ee9d into opensearch-project:main Jan 30, 2024
34 of 35 checks passed

opensearch-trigger-bot bot mentioned this pull request Jan 30, 2024

[Backport 2.x] Updating Ip fields to use doc_values to search #12078

Merged

msfroh approved these changes Jan 30, 2024

View reviewed changes

BrewTestBot mentioned this pull request Feb 21, 2024

opensearch 2.12.0 Homebrew/homebrew-core#163463

Merged

mkhludnev mentioned this pull request Nov 13, 2024

Search dv only IP masks #16628

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating Ip fields to use doc_values to search #11508

Updating Ip fields to use doc_values to search #11508

harshavamsi commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Jan 29, 2024

reta commented Jan 29, 2024

mkhludnev commented Nov 12, 2024

msfroh commented Nov 12, 2024

mkhludnev commented Nov 13, 2024

Updating Ip fields to use doc_values to search #11508

Updating Ip fields to use doc_values to search #11508

Conversation

harshavamsi commented Dec 7, 2023 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Dec 7, 2023 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Jan 29, 2024

reta commented Jan 29, 2024

mkhludnev commented Nov 12, 2024

msfroh commented Nov 12, 2024

mkhludnev commented Nov 13, 2024

harshavamsi commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023 •

edited

Loading