Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix template setting override for replication type #11503

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3b31359 from #11417.

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Compatibility status:

Checks if related components are compatible with change 34946a8

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

github-actions bot commented Dec 7, 2023

❕ Gradle check result for 13f2309: UNSTABLE

  • TEST FAILURES:
      3 org.opensearch.index.shard.RemoteIndexShardTests.classMethod
      1 org.opensearch.index.shard.RemoteIndexShardTests.testReplication

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98b01ec) 70.99% compared to head (978dcd5) 71.15%.
Report is 2 commits behind head on 2.x.

❗ Current head 978dcd5 differs from pull request most recent head 34946a8. Consider uploading reports for the commit 34946a8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11503      +/-   ##
============================================
+ Coverage     70.99%   71.15%   +0.16%     
- Complexity    59183    59305     +122     
============================================
  Files          4880     4880              
  Lines        279148   279149       +1     
  Branches      40894    40894              
============================================
+ Hits         198168   198618     +450     
+ Misses        64194    63762     -432     
+ Partials      16786    16769      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kunal Kotwani <[email protected]>
(cherry picked from commit 3b31359)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kotwanikunal kotwanikunal force-pushed the backport/backport-11417-to-2.x branch from 13f2309 to 34946a8 Compare December 7, 2023 19:13
Copy link
Contributor

github-actions bot commented Dec 7, 2023

❌ Gradle check result for 34946a8: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Dec 7, 2023

❌ Gradle check result for 34946a8: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Dec 7, 2023

✅ Gradle check result for 34946a8: SUCCESS

@kotwanikunal kotwanikunal merged commit 29a5c75 into 2.x Dec 7, 2023
26 checks passed
@github-actions github-actions bot deleted the backport/backport-11417-to-2.x branch December 7, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant