Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for conditional Transient header propagation #11490

Merged
merged 10 commits into from
Jan 9, 2024

Conversation

Gaganjuneja
Copy link
Contributor

@Gaganjuneja Gaganjuneja commented Dec 6, 2023

Description

Skips the Current_Span transient header propagation for the scheduled task. This was messing up with setting up the parent span.

Related Issues

Resolves #10291

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • [] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Gaganjuneja
Copy link
Contributor Author

@reta, Please take a look.

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Compatibility status:

Checks if related components are compatible with change c5614ad

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git]

@peternied peternied dismissed their stale review January 8, 2024 14:38

@reta's callouts around deprecating the old values should go in with these changes

Signed-off-by: Gagan Juneja <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 8, 2024

❌ Gradle check result for 9b9a895: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gagan Juneja <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 8, 2024

❌ Gradle check result for 5697352: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gagan Juneja <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 8, 2024

❌ Gradle check result for ad29c2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gagan Juneja <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 8, 2024

❕ Gradle check result for c5614ad: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta
Copy link
Collaborator

reta commented Jan 8, 2024

@peternied looks good to you? thank you!

@peternied
Copy link
Member

@reta Found an issue with the required-approval tool - fixed it and published a new version, after we merge [1] the update into main the min approval job can succeed

@reta reta merged commit 71f1fab into opensearch-project:main Jan 9, 2024
33 of 36 checks passed
@reta reta added v3.0.0 Issues and PRs related to version 3.0.0 v2.12.0 Issues and PRs related to version 2.12.0 backport 2.x Backport to 2.x branch labels Jan 9, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 9, 2024
* Clear transient header from system context

Signed-off-by: Gagan Juneja <[email protected]>

* Clear transient header from system context

Signed-off-by: Gagan Juneja <[email protected]>

* Adds changelog

Signed-off-by: Gagan Juneja <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Gagan Juneja <[email protected]>

* Adds unit tests

Signed-off-by: Gagan Juneja <[email protected]>

* Refactor code

Signed-off-by: Gagan Juneja <[email protected]>

* Refactor code

Signed-off-by: Gagan Juneja <[email protected]>

* Refactor code

Signed-off-by: Gagan Juneja <[email protected]>

* Supress warning

Signed-off-by: Gagan Juneja <[email protected]>

* Refactor code

Signed-off-by: Gagan Juneja <[email protected]>

---------

Signed-off-by: Gagan Juneja <[email protected]>
Signed-off-by: Gagan Juneja <[email protected]>
Co-authored-by: Gagan Juneja <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
(cherry picked from commit 71f1fab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta added a commit that referenced this pull request Jan 9, 2024
…1823)

* Clear transient header from system context



* Clear transient header from system context



* Adds changelog



* Update CHANGELOG.md




* Adds unit tests



* Refactor code



* Refactor code



* Refactor code



* Supress warning



* Refactor code



---------





(cherry picked from commit 71f1fab)

Signed-off-by: Gagan Juneja <[email protected]>
Signed-off-by: Gagan Juneja <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gagan Juneja <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…project#11490)

* Clear transient header from system context

Signed-off-by: Gagan Juneja <[email protected]>

* Clear transient header from system context

Signed-off-by: Gagan Juneja <[email protected]>

* Adds changelog

Signed-off-by: Gagan Juneja <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Gagan Juneja <[email protected]>

* Adds unit tests

Signed-off-by: Gagan Juneja <[email protected]>

* Refactor code

Signed-off-by: Gagan Juneja <[email protected]>

* Refactor code

Signed-off-by: Gagan Juneja <[email protected]>

* Refactor code

Signed-off-by: Gagan Juneja <[email protected]>

* Supress warning

Signed-off-by: Gagan Juneja <[email protected]>

* Refactor code

Signed-off-by: Gagan Juneja <[email protected]>

---------

Signed-off-by: Gagan Juneja <[email protected]>
Signed-off-by: Gagan Juneja <[email protected]>
Co-authored-by: Gagan Juneja <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…project#11490)

* Clear transient header from system context

Signed-off-by: Gagan Juneja <[email protected]>

* Clear transient header from system context

Signed-off-by: Gagan Juneja <[email protected]>

* Adds changelog

Signed-off-by: Gagan Juneja <[email protected]>

* Update CHANGELOG.md

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Gagan Juneja <[email protected]>

* Adds unit tests

Signed-off-by: Gagan Juneja <[email protected]>

* Refactor code

Signed-off-by: Gagan Juneja <[email protected]>

* Refactor code

Signed-off-by: Gagan Juneja <[email protected]>

* Refactor code

Signed-off-by: Gagan Juneja <[email protected]>

* Supress warning

Signed-off-by: Gagan Juneja <[email protected]>

* Refactor code

Signed-off-by: Gagan Juneja <[email protected]>

---------

Signed-off-by: Gagan Juneja <[email protected]>
Signed-off-by: Gagan Juneja <[email protected]>
Co-authored-by: Gagan Juneja <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Indexing & Search v2.12.0 Issues and PRs related to version 2.12.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracing Instrumentation] Add instrumentation at Local Transport Layer
3 participants