-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for conditional Transient header propagation #11490
Add support for conditional Transient header propagation #11490
Conversation
@reta, Please take a look. |
Compatibility status:Checks if related components are compatible with change c5614ad Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git] |
server/src/main/java/org/opensearch/common/util/concurrent/ThreadContextStatePropagator.java
Show resolved
Hide resolved
@reta's callouts around deprecating the old values should go in with these changes
Signed-off-by: Gagan Juneja <[email protected]>
❌ Gradle check result for 9b9a895: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gagan Juneja <[email protected]>
❌ Gradle check result for 5697352: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gagan Juneja <[email protected]>
server/src/main/java/org/opensearch/tasks/TaskThreadContextStatePropagator.java
Show resolved
Hide resolved
❌ Gradle check result for ad29c2e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gagan Juneja <[email protected]>
❕ Gradle check result for c5614ad: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
@peternied looks good to you? thank you! |
@reta Found an issue with the required-approval tool - fixed it and published a new version, after we merge [1] the update into main the min approval job can succeed |
* Clear transient header from system context Signed-off-by: Gagan Juneja <[email protected]> * Clear transient header from system context Signed-off-by: Gagan Juneja <[email protected]> * Adds changelog Signed-off-by: Gagan Juneja <[email protected]> * Update CHANGELOG.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Gagan Juneja <[email protected]> * Adds unit tests Signed-off-by: Gagan Juneja <[email protected]> * Refactor code Signed-off-by: Gagan Juneja <[email protected]> * Refactor code Signed-off-by: Gagan Juneja <[email protected]> * Refactor code Signed-off-by: Gagan Juneja <[email protected]> * Supress warning Signed-off-by: Gagan Juneja <[email protected]> * Refactor code Signed-off-by: Gagan Juneja <[email protected]> --------- Signed-off-by: Gagan Juneja <[email protected]> Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]> Co-authored-by: Andriy Redko <[email protected]> (cherry picked from commit 71f1fab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…1823) * Clear transient header from system context * Clear transient header from system context * Adds changelog * Update CHANGELOG.md * Adds unit tests * Refactor code * Refactor code * Refactor code * Supress warning * Refactor code --------- (cherry picked from commit 71f1fab) Signed-off-by: Gagan Juneja <[email protected]> Signed-off-by: Gagan Juneja <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Gagan Juneja <[email protected]> Co-authored-by: Andriy Redko <[email protected]>
…project#11490) * Clear transient header from system context Signed-off-by: Gagan Juneja <[email protected]> * Clear transient header from system context Signed-off-by: Gagan Juneja <[email protected]> * Adds changelog Signed-off-by: Gagan Juneja <[email protected]> * Update CHANGELOG.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Gagan Juneja <[email protected]> * Adds unit tests Signed-off-by: Gagan Juneja <[email protected]> * Refactor code Signed-off-by: Gagan Juneja <[email protected]> * Refactor code Signed-off-by: Gagan Juneja <[email protected]> * Refactor code Signed-off-by: Gagan Juneja <[email protected]> * Supress warning Signed-off-by: Gagan Juneja <[email protected]> * Refactor code Signed-off-by: Gagan Juneja <[email protected]> --------- Signed-off-by: Gagan Juneja <[email protected]> Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]> Co-authored-by: Andriy Redko <[email protected]>
…project#11490) * Clear transient header from system context Signed-off-by: Gagan Juneja <[email protected]> * Clear transient header from system context Signed-off-by: Gagan Juneja <[email protected]> * Adds changelog Signed-off-by: Gagan Juneja <[email protected]> * Update CHANGELOG.md Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Gagan Juneja <[email protected]> * Adds unit tests Signed-off-by: Gagan Juneja <[email protected]> * Refactor code Signed-off-by: Gagan Juneja <[email protected]> * Refactor code Signed-off-by: Gagan Juneja <[email protected]> * Refactor code Signed-off-by: Gagan Juneja <[email protected]> * Supress warning Signed-off-by: Gagan Juneja <[email protected]> * Refactor code Signed-off-by: Gagan Juneja <[email protected]> --------- Signed-off-by: Gagan Juneja <[email protected]> Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Skips the Current_Span transient header propagation for the scheduled task. This was messing up with setting up the parent span.
Related Issues
Resolves #10291
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.