Fix flaky test of IndexShardTests.testRestoreLocalHistoryFromTranslogOnPromotion

[dhwanilpatel]

Description

Fix flaky test of IndexShardTests.testRestoreLocalHistoryFromTranslogOnPromotion

Reason of flakyness:

• We perform doc ingestion and update existing doc randomly.
• After that we will generate random no between -1 to max_seqNo, and use it as maxSeqNoOfUpdatesOrDelete on replica operation.
• Here random number should be generated between -1 to maxSeqNoOfUpdatesOrDelete as in first step docs are getting overridden randomly so max_seq no can be higher than maxSeqNoOfUpdatesOrDelete. If generated random number is generated higher than maxSeqNoOfUpdatesOrDelete then it will be updated during performing replica operation and fail the assertion.

Fix:

• Generate random number during replica operation between -1 to maxSeqNoOfUpdatesOrDelete.

Testing

• Test is passing with below seed for which it was failing.
  ./gradlew ':server:test' --tests "org.opensearch.index.shard.IndexShardTests.testRestoreLocalHistoryFromTranslogOnPromotion" -Dtests.seed=2A0B8EBB6B3C284B -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sq-AL -Dtests.timezone=Pacific/Apia

Related Issues

Resolves #6873

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change a11e38b

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

[github-actions]

✅ Gradle check result for a11e38b: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7f3500) 71.37% compared to head (a11e38b) 71.39%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11487      +/-   ##
============================================
+ Coverage     71.37%   71.39%   +0.02%     
+ Complexity    59113    59089      -24     
============================================
  Files          4893     4893              
  Lines        277831   277831              
  Branches      40367    40367              
============================================
+ Hits         198288   198347      +59     
+ Misses        63042    62999      -43     
+ Partials      16501    16485      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[peternied]

Nicely done!