-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test in CardinalityWithRequestBreakerIT #11467
Conversation
Signed-off-by: Neetika Singhal <[email protected]>
Compatibility status:Checks if related components are compatible with change f4275aa Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git] |
❕ Gradle check result for f4275aa: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11467 +/- ##
============================================
- Coverage 71.37% 70.63% -0.74%
+ Complexity 59113 58496 -617
============================================
Files 4893 4893
Lines 277831 277831
Branches 40367 40367
============================================
- Hits 198288 196247 -2041
- Misses 63042 65126 +2084
+ Partials 16501 16458 -43 ☔ View full report in Codecov by Sentry. |
@@ -54,6 +55,7 @@ | |||
import static org.opensearch.search.aggregations.AggregationBuilders.cardinality; | |||
import static org.opensearch.search.aggregations.AggregationBuilders.terms; | |||
|
|||
@OpenSearchIntegTestCase.ClusterScope(scope = OpenSearchIntegTestCase.Scope.SUITE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neetikasinghal apologies, how does it solve the issue? The Scope.SUITE
is the default value for scope
, is it overridden somewhere down the hierarchy? (I was not able to find where)
This doesnt look to be the right fix, closing this pr. |
Description
Specifying the annotation on the IT test helps resolve the flaky test.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#10154
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.