Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Remote Store] Handoff refreshes, translog uploads during relocation from old to new primary (#11330) #11361

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

ashking94
Copy link
Member

Backport ed1c8b7 from #11330.

Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 2585e91

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for 2585e91: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ashking94
Copy link
Member Author

❌ Gradle check result for 2585e91: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Out of the 3 failures, only 1 has failed and this is a flaky test #11032. The other two has passed as per the gradle link - Test 2, Test 3

Copy link
Contributor

❕ Gradle check result for 2585e91: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (cf7ba36) 71.10% compared to head (2585e91) 71.14%.

Files Patch % Lines
...rg/opensearch/index/translog/RemoteFsTranslog.java 72.00% 3 Missing and 4 partials ⚠️
...search/index/shard/RemoteStoreRefreshListener.java 25.00% 0 Missing and 3 partials ⚠️
...in/java/org/opensearch/index/shard/IndexShard.java 83.33% 0 Missing and 2 partials ⚠️
...ndex/shard/ReleasableRetryableRefreshListener.java 88.23% 0 Missing and 2 partials ⚠️
...opensearch/index/translog/NoOpTranslogManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11361      +/-   ##
============================================
+ Coverage     71.10%   71.14%   +0.03%     
- Complexity    59136    59169      +33     
============================================
  Files          4869     4869              
  Lines        278691   278725      +34     
  Branches      40836    40847      +11     
============================================
+ Hits         198171   198287     +116     
+ Misses        63727    63580     -147     
- Partials      16793    16858      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit c1c6494 into opensearch-project:2.x Nov 28, 2023
43 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants