-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build slice level breakdown #11359
Fix build slice level breakdown #11359
Conversation
Signed-off-by: Ticheng Lin <[email protected]>
Compatibility status:Checks if related components are compatible with change 8185d00 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11359 +/- ##
============================================
- Coverage 71.33% 71.23% -0.10%
+ Complexity 58982 58898 -84
============================================
Files 4890 4890
Lines 277468 277470 +2
Branches 40313 40314 +1
============================================
- Hits 197919 197661 -258
- Misses 63127 63367 +240
- Partials 16422 16442 +20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Thanks for fixing this.
Signed-off-by: Ticheng Lin <[email protected]> (cherry picked from commit afa67df) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit afa67df) Signed-off-by: Ticheng Lin <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Ticheng Lin <[email protected]>
Signed-off-by: Ticheng Lin <[email protected]>
Signed-off-by: Ticheng Lin <[email protected]>
Signed-off-by: Ticheng Lin <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
In case where a slice with multiple leaves, it is possible that any one of the leaves has 0 invocations for a specific breakdown type. For instance, let's consider a slice with three leaves: leaf A with a score count of 5, leaf B with a score count of 0, and leaf C with a score count of 4. In this situation, we only compute the timing type slice start/end time based on leaf A and leaf C. This is because leaf B has a start time of zero. And it doesn't represent an actual timing; rather, it indicates no invocations.
Related Issues
Resolves #2775
Check List
New functionality includes testing.New functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.