Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build slice level breakdown #11359

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

ticheng-aws
Copy link
Contributor

Description

In case where a slice with multiple leaves, it is possible that any one of the leaves has 0 invocations for a specific breakdown type. For instance, let's consider a slice with three leaves: leaf A with a score count of 5, leaf B with a score count of 0, and leaf C with a score count of 4. In this situation, we only compute the timing type slice start/end time based on leaf A and leaf C. This is because leaf B has a start time of zero. And it doesn't represent an actual timing; rather, it indicates no invocations.

Related Issues

Resolves #2775

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working CI CI related flaky-test Random test failure that succeeds on second run Search:Performance Search:Resiliency v2.2.0 v3.0.0 Issues and PRs related to version 3.0.0 labels Nov 28, 2023
@ticheng-aws ticheng-aws added skip-changelog v2.12.0 Issues and PRs related to version 2.12.0 labels Nov 28, 2023
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 8185d00

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

✅ Gradle check result for 8185d00: SUCCESS

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c6eb7d) 71.33% compared to head (8185d00) 71.23%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11359      +/-   ##
============================================
- Coverage     71.33%   71.23%   -0.10%     
+ Complexity    58982    58898      -84     
============================================
  Files          4890     4890              
  Lines        277468   277470       +2     
  Branches      40313    40314       +1     
============================================
- Hits         197919   197661     -258     
- Misses        63127    63367     +240     
- Partials      16422    16442      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sohami sohami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks for fixing this.

@sohami sohami added the backport 2.x Backport to 2.x branch label Nov 29, 2023
@sohami sohami merged commit afa67df into opensearch-project:main Nov 29, 2023
121 of 122 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 29, 2023
Signed-off-by: Ticheng Lin <[email protected]>
(cherry picked from commit afa67df)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Nov 29, 2023
(cherry picked from commit afa67df)

Signed-off-by: Ticheng Lin <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ticheng-aws ticheng-aws self-assigned this Nov 29, 2023
fahadshamiinsta pushed a commit to fahadshamiinsta/OpenSearch270 that referenced this pull request Dec 4, 2023
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Dec 11, 2023
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working CI CI related flaky-test Random test failure that succeeds on second run Search:Performance Search:Resiliency skip-changelog v2.2.0 v2.12.0 Issues and PRs related to version 2.12.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
2 participants