-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] fail index template creation with refresh_interval less than cluster minimum #11340
[Remote Store] fail index template creation with refresh_interval less than cluster minimum #11340
Conversation
…minimum Signed-off-by: bansvaru <[email protected]>
Compatibility status:Checks if related components are compatible with change 06af3dc Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git] |
Signed-off-by: bansvaru <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets also handle cluster state restore
…ngs being restored for checking cluster minimum refresh interval Signed-off-by: bansvaru <[email protected]>
Signed-off-by: bansvaru <[email protected]>
❌ Gradle check result for 2129ced: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: bansvaru <[email protected]>
❌ Gradle check result for aa15d86: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Thanks @ashking94 . validations in cluster state update flow can cause issues as it will stop node bootstrap as well. since clusterstate restore doesnt have any manual control and restores whatever it gets from remote as is, i think we should restore without any validations |
Signed-off-by: bansvaru <[email protected]>
❌ Gradle check result for dabfb79: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: bansvaru <[email protected]>
.../internalClusterTest/java/org/opensearch/cluster/metadata/ClusterIndexRefreshIntervalIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: bansvaru <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…s than cluster minimum (#11340) --------- Signed-off-by: bansvaru <[email protected]> (cherry picked from commit 6bc0cd6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…s than cluster minimum (#11340) (#11391) --------- (cherry picked from commit 6bc0cd6) Signed-off-by: bansvaru <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…s than cluster minimum (opensearch-project#11340) --------- Signed-off-by: bansvaru <[email protected]>
…s than cluster minimum (opensearch-project#11340) --------- Signed-off-by: bansvaru <[email protected]>
…s than cluster minimum (opensearch-project#11340) --------- Signed-off-by: bansvaru <[email protected]>
…s than cluster minimum (opensearch-project#11340) --------- Signed-off-by: bansvaru <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
We want to maintain following flows for index refresh interval for Remote Store Clusters. More details in #11348
Related Issues
Resolves #11348
Check List
Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.