Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add template snippets support for field and target_field in KV ingest processor #11300

Merged

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Nov 22, 2023

Description

Backport #10040.

Related Issues

#9964

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… processor (opensearch-project#10040)

* Add template snippets support for field and target_field in KV ingest processor

Signed-off-by: Gao Binlong <[email protected]>

* modify change log

Signed-off-by: Gao Binlong <[email protected]>

* revert replace assertThat by assertEquals

Signed-off-by: Gao Binlong <[email protected]>

* Revert some code

Signed-off-by: Gao Binlong <[email protected]>

* Revert some code

Signed-off-by: Gao Binlong <[email protected]>

* Fix typo and skip some yml test by version

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
(cherry picked from commit 7f4537c)
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 591a190

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Copy link
Contributor

❕ Gradle check result for 591a190: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (847cf9c) 71.02% compared to head (591a190) 71.07%.

Files Patch % Lines
...rg/opensearch/ingest/common/KeyValueProcessor.java 91.66% 2 Missing and 1 partial ⚠️
...g/opensearch/ingest/common/IngestCommonPlugin.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11300      +/-   ##
============================================
+ Coverage     71.02%   71.07%   +0.05%     
- Complexity    59071    59138      +67     
============================================
  Files          4869     4869              
  Lines        278636   278654      +18     
  Branches      40826    40830       +4     
============================================
+ Hits         197888   198058     +170     
+ Misses        63996    63855     -141     
+ Partials      16752    16741      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 5913b21 into opensearch-project:2.x Nov 22, 2023
80 checks passed
@gaobinlong gaobinlong deleted the backport/backport-10040-to-2.x branch June 19, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants