Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] [2.x] [BUG] The thread context is not properly cleared and messes up the traces (#10873) #11277

Merged
merged 2 commits into from
Nov 21, 2023
Merged

[Backport] [2.x] [BUG] The thread context is not properly cleared and messes up the traces (#10873) #11277

merged 2 commits into from
Nov 21, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Nov 20, 2023

Backport of the #10873 to 2.x

@reta
[BUG] The thread context is not properly cleared and messes up the tr…
04fa63f 
…aces (opensearch-project#10873)

* [BUG] The thread context is not properly cleared and messes up the traces

Signed-off-by: Andriy Redko <[email protected]>

* Address code review comments

Signed-off-by: Andriy Redko <[email protected]>

* Address code review comments

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 00517eb)
@reta reta added the v2.12.0 Issues and PRs related to version 2.12.0 label Nov 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 897fd51

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 04fa63f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented Nov 20, 2023

❌ Gradle check result for 04fa63f: FAILURE

#11258

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 04fa63f: SUCCESS

@reta
Copy link
Collaborator Author

reta commented Nov 20, 2023

@andrross @kotwanikunal mind please approving the backport? thank you

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 897fd51: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (15d3014) 71.01% compared to head (897fd51) 71.01%.
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...ava/org/opensearch/transport/TransportService.java 93.10% 1 Missing and 1 partial ⚠️
.../fieldcomparator/DoubleValuesComparatorSource.java 0.00% 0 Missing and 1 partial ⚠️
...a/fieldcomparator/FloatValuesComparatorSource.java 0.00% 0 Missing and 1 partial ⚠️
...eldcomparator/HalfFloatValuesComparatorSource.java 0.00% 1 Missing ⚠️
...ata/fieldcomparator/IntValuesComparatorSource.java 0.00% 0 Missing and 1 partial ⚠️
...ta/fieldcomparator/LongValuesComparatorSource.java 0.00% 0 Missing and 1 partial ⚠️
...comparator/UnsignedLongValuesComparatorSource.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                2.x   #11277   +/-   ##
=========================================
  Coverage     71.01%   71.01%           
+ Complexity    59092    59078   -14     
=========================================
  Files          4869     4869           
  Lines        278632   278631    -1     
  Branches      40825    40826    +1     
=========================================
+ Hits         197857   197862    +5     
+ Misses        64058    63987   -71     
- Partials      16717    16782   +65

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit ea99d7e into opensearch-project:2.x Nov 21, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reta @andrross