Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] [2.x] [BWC and API enforcement] Decorate the existing APIs with proper annotations (part 3) (#11182) #11231

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[Backport] [2.x] [BWC and API enforcement] Decorate the existing APIs with proper annotations (part 3) (#11182) #11231

merged 1 commit into from
Nov 16, 2023
+1,405 −506

Conversation

reta
Copy link
Collaborator

@reta reta commented Nov 16, 2023

Backport of #11182 to 2.x

@reta
[BWC and API enforcement] Decorate the existing APIs with proper anno…
cfd64ae 
…tations (part 3) (opensearch-project#11182)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 09bacee)
@github-actions GitHub Actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change cfd64ae

Incompatible components

Incompatible components: [https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git]

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for cfd64ae: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68523e7) 70.85% compared to head (cfd64ae) 70.97%.
Report is 3 commits behind head on 2.x.

Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #11231      +/-   ##
============================================
+ Coverage     70.85%   70.97%   +0.11%     
- Complexity    58869    59028     +159     
============================================
  Files          4864     4867       +3     
  Lines        278455   278455              
  Branches      40813    40810       -3     
============================================
+ Hits         197294   197625     +331     
+ Misses        64348    64035     -313     
+ Partials      16813    16795      -18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Collaborator Author

reta commented Nov 16, 2023

@andrross whenever you have time please - manual backport to 2.x - thank you

@andrross andrross merged commit 78cfce4 into opensearch-project:2.x Nov 16, 2023
54 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reta @andrross