-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Refactor common parts from the Rounding class into a separate 'round' package (#11023) #11223
[Backport 2.x] Refactor common parts from the Rounding class into a separate 'round' package (#11023) #11223
Conversation
Compatibility status:Checks if related components are compatible with change 596cda4 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git] |
❌ Gradle check result for 15667ee: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…eparate 'round' package (opensearch-project#11023) (cherry picked from commit 08db961) Signed-off-by: Ketan Verma <[email protected]>
15667ee
to
596cda4
Compare
❕ Gradle check result for 596cda4: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #11223 +/- ##
==========================================
Coverage 70.90% 70.91%
- Complexity 58877 58969 +92
==========================================
Files 4864 4867 +3
Lines 278455 278457 +2
Branches 40813 40810 -3
==========================================
+ Hits 197449 197461 +12
- Misses 64127 64273 +146
+ Partials 16879 16723 -156 ☔ View full report in Codecov by Sentry. |
Description
Manual backport of #11023
(cherry picked from commit 08db961)
Check List
Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.