Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Refactor common parts from the Rounding class into a separate 'round' package (#11023) #11223

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

ketanv3
Copy link
Contributor

@ketanv3 ketanv3 commented Nov 15, 2023

Description

Manual backport of #11023

(cherry picked from commit 08db961)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 15, 2023

Compatibility status:

Checks if related components are compatible with change 596cda4

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Copy link
Contributor

❌ Gradle check result for 15667ee: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…eparate 'round' package (opensearch-project#11023)

(cherry picked from commit 08db961)

Signed-off-by: Ketan Verma <[email protected]>
@ketanv3 ketanv3 force-pushed the backport/backport-11023-to-2.x branch from 15667ee to 596cda4 Compare November 15, 2023 23:33
@reta reta added the >breaking Identifies a breaking change. label Nov 16, 2023
@reta reta added v2.12.0 Issues and PRs related to version 2.12.0 and removed >breaking Identifies a breaking change. labels Nov 16, 2023
Copy link
Contributor

❕ Gradle check result for 596cda4: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testStatsResponseAllShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa035ab) 70.90% compared to head (596cda4) 70.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##                2.x   #11223    +/-   ##
==========================================
  Coverage     70.90%   70.91%            
- Complexity    58877    58969    +92     
==========================================
  Files          4864     4867     +3     
  Lines        278455   278457     +2     
  Branches      40813    40810     -3     
==========================================
+ Hits         197449   197461    +12     
- Misses        64127    64273   +146     
+ Partials      16879    16723   -156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 39baeb8 into opensearch-project:2.x Nov 16, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants