Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Per request latency onPhaseEnd fix (#10934) #11218

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

dzane17
Copy link
Contributor

@dzane17 dzane17 commented Nov 15, 2023

Signed-off-by: David Zane [email protected]
(cherry picked from commit 379acf3)

Description

Backport 2.x for #10934

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: David Zane <[email protected]>
(cherry picked from commit 379acf3)
@dzane17 dzane17 changed the title Per request latency onPhaseEnd fix (#10934) [backport] Per request latency onPhaseEnd fix (#10934) Nov 15, 2023
@dzane17 dzane17 changed the title [backport] Per request latency onPhaseEnd fix (#10934) [Backport 2.x] Per request latency onPhaseEnd fix (#10934) Nov 15, 2023
@dzane17 dzane17 marked this pull request as ready for review November 15, 2023 17:41
Copy link
Contributor

github-actions bot commented Nov 15, 2023

Compatibility status:

Checks if related components are compatible with change 6330159

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git]

Copy link
Contributor

✅ Gradle check result for b95e1cb: SUCCESS

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa035ab) 70.90% compared to head (6330159) 70.82%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11218      +/-   ##
============================================
- Coverage     70.90%   70.82%   -0.09%     
- Complexity    58877    58918      +41     
============================================
  Files          4864     4864              
  Lines        278455   278455              
  Branches      40813    40813              
============================================
- Hits         197449   197224     -225     
- Misses        64127    64425     +298     
+ Partials      16879    16806      -73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 6330159: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 6330159: SUCCESS

@msfroh msfroh merged commit a6748e0 into opensearch-project:2.x Nov 16, 2023
72 checks passed
@dzane17 dzane17 deleted the backport/backport-10934-to-2.x branch November 16, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants