Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed flaky and failing test cases for concurrent search #11183

Closed
wants to merge 4 commits into from

Conversation

e-emoto
Copy link
Contributor

@e-emoto e-emoto commented Nov 13, 2023

Description

This makes use of the indexRandomForConcurrentSearch function, which creates more segments for concurrent search tests, in several test cases for their concurrent search use-cases. The following test suites are affected by this change:

  • RandomScoreFunctionIT.java
  • FetchSubPhasePluginIT.java
  • SearchWhileRelocatingIT.java

Related Issues

Resolves #11112
Resolves #11106

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

e-emoto and others added 4 commits November 7, 2023 17:42
            Fixed test cases
            Updated fix for TransportTwoNodesSearchIT test cases
            Updated test cases and muted flaky tests
            Move indexRandomForConcurrentSearch call into prepareData
            Remove changes from TransportTwoNodesSearchIT.java until future fix

Signed-off-by: Ethan Emoto <[email protected]>
Updated fix for TransportTwoNodesSearchIT test cases

Updated test cases and muted flaky tests

Fixed test cases for concurrent search
            Updated flaky and failing test cases after changes to indexRandomForConcurrentSearch

Signed-off-by: Ethan Emoto <[email protected]>
@e-emoto e-emoto requested a review from VachaShah as a code owner November 13, 2023 21:51
@github-actions github-actions bot added the bug Something isn't working label Nov 13, 2023
@e-emoto e-emoto closed this Nov 13, 2023
@e-emoto e-emoto deleted the test-changes branch November 13, 2023 21:55
Copy link
Contributor

❌ Gradle check result for d9835cd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change d9835cd

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant