Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix slice collectors to leaves association with post filter #11150

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3eda422 from #11134.

* Fix slice collectors to leaves association with profile enabled (#11134)

Signed-off-by: Ticheng Lin <[email protected]>

* Update server/src/main/java/org/opensearch/search/profile/query/ConcurrentQueryProfileBreakdown.java

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Ticheng Lin <[email protected]>
Signed-off-by: Ticheng Lin <[email protected]>

---------

Signed-off-by: Ticheng Lin <[email protected]>
Signed-off-by: Ticheng Lin <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
(cherry picked from commit 3eda422)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Compatibility status:

Checks if related components are compatible with change ab80e05

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Gradle Check (Jenkins) Run Completed with:

@ticheng-aws
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

This is a known flaky test #10006

Tests with failures:
 - org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

4538 tests completed, 1 failed, 40 skipped

@ticheng-aws
Copy link
Contributor

Hi @reta, could you help to trigger another gradle check here? Thank you.

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Nov 10, 2023

Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #11150 (ab80e05) into 2.x (870ecd3) will decrease coverage by 0.05%.
Report is 7 commits behind head on 2.x.
The diff coverage is 56.56%.

@@             Coverage Diff              @@
##                2.x   #11150      +/-   ##
============================================
- Coverage     70.98%   70.94%   -0.05%     
- Complexity    58895    58957      +62     
============================================
  Files          4851     4862      +11     
  Lines        278023   278394     +371     
  Branches      40765    40810      +45     
============================================
+ Hits         197358   197500     +142     
- Misses        63872    64127     +255     
+ Partials      16793    16767      -26     
Files Coverage Δ
...nsearch/http/netty4/Netty4HttpServerTransport.java 75.75% <ø> (ø)
...search/common/lucene/search/FilteredCollector.java 100.00% <100.00%> (ø)
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <ø> (ø)
...ava/org/opensearch/http/HttpTransportSettings.java 96.15% <100.00%> (+0.07%) ⬆️
...http/reactor/netty4/ReactorNetty4HttpResponse.java 85.71% <85.71%> (ø)
...ansport/reactor/netty4/ReactorNetty4Transport.java 75.00% <75.00%> (ø)
...reactor/netty4/ReactorNetty4HttpServerChannel.java 83.33% <83.33%> (ø)
...profile/query/ConcurrentQueryProfileBreakdown.java 93.56% <0.00%> (-1.08%) ⬇️
...g/opensearch/index/mapper/GeoShapeFieldMapper.java 80.00% <62.50%> (-3.64%) ⬇️
...h/http/reactor/netty4/NonStreamingHttpChannel.java 66.66% <66.66%> (ø)
... and 7 more

... and 482 files with indirect coverage changes

@reta reta merged commit 822e253 into 2.x Nov 10, 2023
42 of 69 checks passed
@github-actions github-actions bot deleted the backport/backport-11134-to-2.x branch November 10, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants