Manually backport #11060 (Simple regex normalization refactor)

[stephen-crawford]

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[stephen-crawford]

@reta can you mark this 2.11 backport please?

[reta]

@reta can you mark this 2.11 backport please?

@scrawfor99 we need to align with the release team, @bbarani @CEHENKLE please signoff if we are OK bringing this one into 2.11.1, thank you

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29780/
• CommitID: de9047c
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Compatibility status:

Checks if related components are compatible with change e0f6b38

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29786/
• CommitID: e0f6b38
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[bbarani]

I am good with backporting this fix to 2.11 branch and release in 2.11.1 patch version.

[reta]

• URL: https://build.ci.opensearch.org/job/gradle-check/29786/

#10154
#10558

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29792/
• CommitID: e0f6b38
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[reta]

• URL: https://build.ci.opensearch.org/job/gradle-check/29792/

#8932
#11155

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/29808/
• CommitID: e0f6b38

[codecov]

Codecov Report

Merging #11147 (e0f6b38) into 2.x (870ecd3) will increase coverage by 0.05%.
Report is 8 commits behind head on 2.x.
The diff coverage is 58.54%.

@@             Coverage Diff              @@
##                2.x   #11147      +/-   ##
============================================
+ Coverage     70.98%   71.03%   +0.05%     
- Complexity    58895    58994      +99     
============================================
  Files          4851     4862      +11     
  Lines        278023   278385     +362     
  Branches      40765    40805      +40     
============================================
+ Hits         197358   197758     +400     
+ Misses        63872    63808      -64     
- Partials      16793    16819      +26     

Files	Coverage Δ
...nsearch/http/netty4/Netty4HttpServerTransport.java	75.75% <ø> (ø)
...c/main/java/org/opensearch/common/regex/Regex.java	86.00% <100.00%> (-0.54%)	⬇️
...rg/opensearch/common/settings/ClusterSettings.java	92.85% <ø> (ø)
...ava/org/opensearch/http/HttpTransportSettings.java	96.15% <100.00%> (+0.07%)	⬆️
...http/reactor/netty4/ReactorNetty4HttpResponse.java	85.71% <85.71%> (ø)
...ansport/reactor/netty4/ReactorNetty4Transport.java	75.00% <75.00%> (ø)
...reactor/netty4/ReactorNetty4HttpServerChannel.java	83.33% <83.33%> (ø)
...g/opensearch/index/mapper/GeoShapeFieldMapper.java	80.00% <62.50%> (-3.64%)	⬇️
...h/http/reactor/netty4/NonStreamingHttpChannel.java	66.66% <66.66%> (ø)
...tp/reactor/netty4/NonStreamingRequestConsumer.java	77.77% <77.77%> (ø)
... and 6 more

... and 482 files with indirect coverage changes

[opensearch-trigger-bot]

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/backport-2.11
# Create a new branch
git switch --create backport/backport-11147-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 725d505f49c7d319aa52e550febcaad07eb4e0bf
# Push it to GitHub
git push --set-upstream origin backport/backport-11147-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport/backport-11147-to-2.11.

[reta]

@scrawfor99 2.11 backport failed :(

[cwperks]

@reta @scrawfor99 I opened up a manual backport to 2.11: #11185