Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmute FieldCapabilitiesIT.testWithIndexFilter for concurrent search #11110

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented Nov 6, 2023

Test was originally muted for concurrent search in #10437
This test was fixed already so unmuting, see #10474 (comment).

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jed326
Copy link
Collaborator Author

jed326 commented Nov 6, 2023

@reta could you help review this too? It seems like this test has been fixed so unmuting it.

@jed326 jed326 changed the title Unmute FieldCapabilitiesIT.testWithIndexFilter Unmute FieldCapabilitiesIT.testWithIndexFilter for concurrent search Nov 6, 2023
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Compatibility status:

Checks if related components are compatible with change 63a61ba

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git]

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

@jed326
Copy link
Collaborator Author

jed326 commented Nov 7, 2023

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #11110 (63a61ba) into main (747f7d1) will decrease coverage by 0.08%.
Report is 5 commits behind head on main.
The diff coverage is 56.50%.

@@             Coverage Diff              @@
##               main   #11110      +/-   ##
============================================
- Coverage     71.20%   71.13%   -0.08%     
- Complexity    58716    58738      +22     
============================================
  Files          4872     4883      +11     
  Lines        276773   277134     +361     
  Branches      40240    40284      +44     
============================================
+ Hits         197078   197133      +55     
- Misses        63238    63529     +291     
- Partials      16457    16472      +15     
Files Coverage Δ
...nsearch/http/netty4/Netty4HttpServerTransport.java 56.18% <ø> (ø)
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <ø> (ø)
...ava/org/opensearch/http/HttpTransportSettings.java 96.15% <100.00%> (+0.07%) ⬆️
...http/reactor/netty4/ReactorNetty4HttpResponse.java 85.71% <85.71%> (ø)
...ansport/reactor/netty4/ReactorNetty4Transport.java 75.00% <75.00%> (ø)
...reactor/netty4/ReactorNetty4HttpServerChannel.java 83.33% <83.33%> (ø)
...h/http/reactor/netty4/NonStreamingHttpChannel.java 66.66% <66.66%> (ø)
...tp/reactor/netty4/NonStreamingRequestConsumer.java 77.77% <77.77%> (ø)
...nsearch/transport/reactor/ReactorNetty4Plugin.java 7.69% <7.69%> (ø)
...search/http/reactor/netty4/HttpConversionUtil.java 26.31% <26.31%> (ø)
... and 4 more

... and 485 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

@reta reta merged commit 145fd9e into opensearch-project:main Nov 7, 2023
28 of 29 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Nov 7, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2023
… search (#11110)

Signed-off-by: Jay Deng <[email protected]>
(cherry picked from commit 145fd9e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Nov 8, 2023
… search (#11110) (#11127)

(cherry picked from commit 145fd9e)

Signed-off-by: Jay Deng <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants