Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing Tracing instrumentation : auto-create indices and threadool queue waiting #11084

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rayshrey
Copy link
Contributor

@rayshrey rayshrey commented Nov 3, 2023

Description

Added indexing instrumentation in following additional paths:

  • Auto creation of indices
  • Threadpool waiting time for bulk request execution

Screenshots

Screenshot 2023-11-03 at 7 46 50 PM Screenshot 2023-11-03 at 7 48 34 PM Screenshot 2023-11-03 at 7 48 08 PM Screenshot 2023-11-03 at 7 47 46 PM Screenshot 2023-11-03 at 7 47 34 PM

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rayshrey please hold on with these changes, we have issues with context propagation, see please #10789

@rayshrey
Copy link
Contributor Author

rayshrey commented Nov 3, 2023

we have issues with context propagation, see please #10789

@reta Yes even I seemed to encounter them.
An issue was opened by @Gaganjuneja for a similar problem -> #10090

Will hold on to this for time being.

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Compatibility status:

Checks if related components are compatible with change 418b7dc

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshSuccessOnSecondAttempt

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: Patch coverage is 82.22222% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 71.31%. Comparing base (b15cb0c) to head (7dedbe9).
Report is 311 commits behind head on main.

Current head 7dedbe9 differs from pull request most recent head 418b7dc

Please upload reports for the commit 418b7dc to get more accurate results.

Files Patch % Lines
...tion/support/replication/TransportWriteAction.java 77.77% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11084      +/-   ##
============================================
- Coverage     71.42%   71.31%   -0.11%     
+ Complexity    59978    58787    -1191     
============================================
  Files          4985     4872     -113     
  Lines        282275   276813    -5462     
  Branches      40946    40241     -705     
============================================
- Hits         201603   197423    -4180     
+ Misses        63999    62942    -1057     
+ Partials      16673    16448     -225     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Dec 3, 2023
@ticheng-aws
Copy link
Contributor

Hi @rayshrey, Is this being worked upon? Feel free to reach out to maintainers for further reviews.

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jan 6, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Feb 6, 2024
@reta
Copy link
Collaborator

reta commented Feb 6, 2024

@rayshrey could you please revive this pull request? the blocker seems to be addressed, thank you

@reta reta self-requested a review February 6, 2024 15:26
@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Feb 7, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Mar 10, 2024
@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Mar 17, 2024
@rayshrey rayshrey requested a review from tlfeng as a code owner March 18, 2024 08:44
Copy link
Contributor

❌ Gradle check result for 157b83f:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for fbcc0d9:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rayshrey rayshrey reopened this Mar 18, 2024
Copy link
Contributor

❌ Gradle check result for 418b7dc: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 418b7dc:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Apr 20, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants