-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support allow_duplicate_keys for json processor #11059
Support allow_duplicate_keys for json processor #11059
Conversation
aa08236
to
59121c1
Compare
Compatibility status:Checks if related components are compatible with change 7498602 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git] |
Gradle Check (Jenkins) Run Completed with:
|
59121c1
to
3d434b0
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
3d434b0
to
9492ce9
Compare
Gradle Check (Jenkins) Run Completed with:
|
8d272d2
to
b6326b5
Compare
Gradle Check (Jenkins) Run Completed with:
|
b6326b5
to
e787739
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
e787739
to
d39a702
Compare
Gradle Check (Jenkins) Run Completed with:
|
d39a702
to
1a1420e
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Munif Tanjim <[email protected]>
1a1420e
to
7498602
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #11059 +/- ##
============================================
- Coverage 71.29% 71.25% -0.04%
- Complexity 58742 58750 +8
============================================
Files 4872 4872
Lines 276777 276791 +14
Branches 40240 40241 +1
============================================
- Hits 197316 197218 -98
- Misses 62943 63157 +214
+ Partials 16518 16416 -102
|
This PR is stalled because it has been open for 30 days with no activity. |
This is still relevant! @opensearch-ci-bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, not sure how we missed the PR. Sorry about that. Please iterate to green. Needs a CHANGELOG notably.
I don't know much about the xcontent business, maybe @reta can review this? Who else?
Thanks for the pull request @MunifTanjim but we cannot port features from elasticsearch "as-is" without violating license |
Oh I didn't notice the port from Elastic. That PR is from Jul 6, 2021 which is after 7.10.2 I believe, closing this PR. Anyone wanting this feature in OpenSearch: please ensure that you're not copying any non-APLv2 code. |
Description
This is to support creating an ingest pipeline for ECS JSON logs.
Due to how some logging frameworks work, ECS JSON logs may contain duplicate keys. Instead of failing, the JSON parser should be more lenient and prefer the last value.
Ported from elastic/elasticsearch#74956
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.