Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Remove primary targets from replication tracker #11011

Merged

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Oct 31, 2023

Description

Removes primary relocation targets from replication tracker. This is required to allow correct operations when underlying replication type is "segment".

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 5ebd5a7

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@dreamer-89 dreamer-89 added the backport 2.x Backport to 2.x branch label Oct 31, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

#10704

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #11011 (5ebd5a7) into main (9d85e56) will decrease coverage by 0.09%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##               main   #11011      +/-   ##
============================================
- Coverage     71.22%   71.14%   -0.09%     
+ Complexity    58732    58671      -61     
============================================
  Files          4872     4872              
  Lines        276671   276679       +8     
  Branches      40206    40210       +4     
============================================
- Hits         197064   196842     -222     
- Misses        63187    63364     +177     
- Partials      16420    16473      +53     
Files Coverage Δ
...org/opensearch/index/seqno/ReplicationTracker.java 68.69% <87.50%> (-0.36%) ⬇️

... and 440 files with indirect coverage changes

@dreamer-89 dreamer-89 merged commit 9c65350 into opensearch-project:main Oct 31, 2023
60 of 116 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 31, 2023
…#11011)

Signed-off-by: Suraj Singh <[email protected]>
(cherry picked from commit 9c65350)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89 pushed a commit that referenced this pull request Oct 31, 2023
…#11011) (#11012)

(cherry picked from commit 9c65350)

Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants